On Tue, May 10, 2011 at 1:24 PM, Igor Stasenko <siguctua@gmail.com> wrote:
Okay, seems like i found the bug.
(CompiledMethodTrailer new sourcePointer: 0) testEncoding
fails.
And it happens only when you pass 0 as source pointer!! Such an obscure case!
So...this means that after a day and a half of work of the whole community we finally fix it?? I am happy. Thanks Igor and the rest who helped as well :) Now...I am not sure if I understand. I saw your changes and you test. But my question is what happen with those incorrect CM that are arround. It means that the next build image, when it does the CompiledMethod cleanUp and destroy the sourcePointers, I will let correct CMs ? Does it mean that if I build a dev image now with such fix, I won't have these weird CMs bothering me? Ok....I am trying now.... Thanks a lot to everybody for the effort, Mariano
@squeakers, for the context, check the discussion "Problem with CompiledMethodTrailer" in pharo-dev list.
On 10 May 2011 12:47, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
I must be wrong, because the dev image when it is build, it calls all cleanUp methods for classes, so CompiledMethod class >> cleanUp shuld have been called, but if I take the Pharo1.3 result, I can see the source code (not decompiled)
But you can't see the source of those methods in browser, because browser works only with installed methods while cleanup touching only non-installed ones.
grrrr sorry, I forgot about the #isInstalled ... I went directly to see #destroySourcePointer heheheh
When i do this, my image hangs.
I have just tried and it crash!!! Actually, I evaluated
CompiledMethod
cleanUp. And just after cmd+b in CompiledMethod (to browse it) -> crash How it is possilbe it didn't crash while building the dev image? or the first time I browse a class? maybe this incorrect CM are created by the build process just after the cleanUp ?
I don't know yet. Maybe there is some test, which breaking them when it runs? Or tests are not run on those images?
I was thinking exactly the same. But no, this image has not run the tests. There are other images specially to download from hudson that are those after running tests :(
-- Mariano http://marianopeck.wordpress.com
-- Best regards, Igor Stasenko AKA sig.
-- Mariano http://marianopeck.wordpress.com