I asked damien because I thought it was something he already did to ease Nile integration. On Sep 2, 2009, at 7:35 PM, Henrik Johansen wrote:
Loads fine for me, and tests remain unchanged. Also seems like a reasonable change. Will you do WriteStream on: and friends next? ;)
Cheers, Henry
On Sep 2, 2009, at 6:21 35PM, Peter Hugosson-Miller wrote:
Hi there,
This is my first contribution to PharO :-)
I've followed the instructions on the "How to Contribute" page, and there is now a bunch of packages, and a SLICE-package that depends on all of them (named in the subject of this message) in the PharO inbox. One of the packages (KernelTests-PeterHugossonMiller. 142.mcz) I have managed to miss the log message, but otherwise I believe I have done everything correctly. I attach screenshots of the TestRunner results run before and after my changes.
Please could someone review the changes and let me know how I did.
-- Cheers, Peter
Before my changes:
<Before_RemoveReferencesToReadStreamOn.png>
After my changes: <After_RemoveReferencesToReadStreamOn.png>
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project