On Tue, Jun 12, 2012 at 9:54 AM, Esteban Lorenzano <estebanlm@gmail.com>wrote:
no, I vote for #deleteIfAbsent: too
fuc...I hate discussing in IRC. I won't do it again... In IRC we said that even if I have #deleteIfAbsent: it is NOT enough. I don't want to have to do aReference deleteIfAbsent: [] all the time...I don't like it. So I want #ensureDeleted or #deleteIfExists, and yes, it can rely on #deleteIfAbsent: if desired, I don't care. cheers
On Jun 12, 2012, at 9:49 AM, Mariano Martinez Peck wrote:
Hi Stef. It looks we are minority. So today I will: - add #testExists (becuase it was broken but no test) - add #ensureDeleted - add #testEnsureDeleted - fix FileSystemHandleTest >> tearDown to #ensureDeleted the reference.
cheers
On Tue, Jun 12, 2012 at 7:25 AM, Stéphane Ducasse < stephane.ducasse@inria.fr> wrote:
Yes to me ensureDelete or ensureDeleted is not explicit enough. I prefer remove/delete[ifAbsent:] On Jun 12, 2012, at 1:41 AM, Schwab,Wilhelm K wrote:
I generally default to saying "of course there should be an error." I much prefer to get my bad news early rather than having to fish around or it after the fact. Toward that end, I would recommend having #deleteIfAbsent: and #delete that provides an error-raising block and forwards to #deleteifAbsent:. That is consistent with collections, which are not a bad model/source-of-inspiration for managing directory contents.
Having #ensureDeleted in addition to above does no real harm. I would prefer that the selector start with "delete" so it appears close to the other methods in browsers, even w/o category filtering - makes it more discoverable.
Just my 2 asCents.
Bill
________________________________________ From: pharo-project-bounces@lists.gforge.inria.fr [ pharo-project-bounces@lists.gforge.inria.fr] on behalf of Chris Cunningham [cunningham.cb@gmail.com] Sent: Monday, June 11, 2012 5:55 PM To: Pharo-project@lists.gforge.inria.fr Subject: Re: [Pharo-project] FileReference should throw error when deleting unexisting files?
On Mon, Jun 11, 2012 at 2:32 PM, <petton.nicolas@gmail.com> wrote:
Maybe #ensureDeleted would be better?
Nico I like #ensureDeleted (make sure it doesn't exist)
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com