---------- Forwarded message ---------- From: Séverin Lemaignan <severin.lemaignan@laas.fr> Date: 2011/1/28 Subject: Re: [Pharo-project] Issue 3599 in pharo: Serial Port To: Serge Stinckwich <serge.stinckwich@gmail.com> Cc: Pharo-project@lists.gforge.inria.fr
The quality of the code is not really good, there is a lot of isString everywhere in order to test if the port is a number or a string regarding the OS platform used:
I did so to avoid to break anything that could already used the com port with integers. If you're confident it's not used (or if it is easy enough to convert it to 'com1', 'com2' strings...) then feel free to remove support for integer. As far as I remember, the underlying system primitive should be able to deal with 'comX' on Windows. Regards, Severin --     Séverin Lemaignan - severin.lemaignan@laas.fr  [00]   PhD student on Cognitive Robotics /|__|\  LAAS-CNRS - RIS group / Technische Uni München - IAS group  ''   +33561337844 / +498928917780     http://www.laas.fr/~slemaign -- Serge Stinckwich UMI UMMISCO 209 (IRD/UPMC), Hanoi, Vietnam Every DSL ends up being Smalltalk http://doesnotunderstand.org/