Hi: On 13 Mar 2013, at 15:38, Frank Shearar wrote:
Cool, thanks Stefan. I only found out about the confusion of repositories after I sent you Phexample-fbs.64 - did it pass all tests on Pharo 1.4? If so, and you're OK with the change, I'll rebase my work off the latest version and resubmit. I'll also edit the ConfigurationOf to add a #squeak section.
I finally got around to solve the includesSub[sS]tring issue. I also fixed the #isTest: on the class side of Phexample and use it. All together with tests documenting the desired behavior. I chose to use packages for the platform specific stuff: - PhexamplePlatform-Pharo14 (should also work with Squeak 4.4 and 4.5) - PhexamplePlatform-Pharo20 The tests do not completely run on Squeak 4.4, Frank, if you need that, please have a look. I did not tests with Squeak 4.5. On my machine, tests pass for Pharo 1.4 and Pharo 2.0 Camillo, you set up the Jenkins project? https://ci.inria.fr/pharo-contribution/job/Phexample/ I tried to be patient, but it does not look like the build got triggered. Is there anything I need to do other then publish in the code in: http://smalltalkhub.com/#!/~Phexample/Phexample? Thanks Stefan -- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 2974 Fax: +32 2 629 3525