Hi Pavel, On Mon, Mar 12, 2012 at 1:40 AM, Pavel Krivanek <pavel.krivanek@gmail.com>wrote:
Thank you, Eliot. I updated the issue report.
I'm grabbing the changes for Squeak trunk. But I don't see why one should do cleanOutUndeclared in testMethodsWithUnboundGlobals. It doesn't affect the result of the test (since methodsWittUnboundGlobals filters-out Undeclared) and introduces a side-effect of running tests.
-- Pavel
On Sun, Mar 11, 2012 at 11:36 PM, Eliot Miranda <eliot.miranda@gmail.com> wrote:
On Sun, Mar 11, 2012 at 3:33 PM, Eliot Miranda <eliot.miranda@gmail.com> wrote:
Hi Pavel,
I presume they are found by the following:
SystemNavigation new browseAllSelect: [:m| m literals anySatisfy: [:l| l isVariableBinding and: [l key isSymbol "avoid class-side methodClass literals" and: [(m methodClass bindingOf: l key) isNil]]]]
This could be a "browse unbound", and could be included in release tests via e.g.
SystemNavigation>methodsWithUnboundGlobals ^self allSelect: [:m| m literals anySatisfy: [:l| l isVariableBinding and: [l key isSymbol "avoid class-side methodClass literals" and: [(m methodClass bindingOf: l key) isNil]]]]
(or whereever Pharo puts browsing queries these days)
and I suppose it should exclude Undeclared variables, so this is better:
SystemNavigation new browseAllSelect: [:m| m literals anySatisfy: [:l| l isVariableBinding and: [l key isSymbol "avoid class-side methodClass literals" and: [(m methodClass bindingOf: l key) isNil and: [(Undeclared includesAssociation: l) not]]]]]
On Sun, Mar 11, 2012 at 10:43 AM, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:
Hi,
the method DefaultSettingStyle>>#load includes several obsolete classes (RBProgramNode, RBConfigurableFormatter, RefactoryChangeManager). It is interesting that this inconsistency is not reported by Undeclared nor obsoleteClasses (so release tests are green). The literals array contains associations to nil pointed only from the literal array of this method.
http://code.google.com/p/pharo/issues/detail?id=5463
Cheers, -- Pavel
-- best, Eliot
-- best, Eliot
-- best, Eliot