On 28 Jul 2011, at 21:43, Sven Van Caekenberghe wrote:
On 28 Jul 2011, at 20:54, Lukas Renggli wrote:
I don't think that the server manager calls #basicStop/#basicStart on startup/shutdown (this is when you explicitly start/stop the server), only #startUp/#shutDown. I might be wrong though ...
Then why not implement #startUp/#shutDown by delegating to #basicStop/#basicStart
Maybe Philippe knows the finer points.
OK, I went over the code looking for the relationship between WAServerManager and WAServerAdaptor. The difference between #startUp/#shutDown and #basicStop/#basicStart is intentional and necessary, and as far as I can see and understand it your patch fixes things. The start adaptor / stop adaptor logic from the control panel goes like this: adaptor start -> manager start: adaptor -> adaptor basicStart The manager's startUp/shutDown calls each adaptor's startUp/shutDown. There is no need for Zn managing this as a registered server since the manager does all the work already Thanks! Sven