On Jan 12, 2010, at 1:32 PM, Fernando olivero wrote:
Stef, i've started from CUIS.
This is what i have done so far.
1. Added the System-TextAttributes category 2. Moved the classes from Collections-Text to System-TextAttributes 3. Added System-Text category 4. Move Text from Collections-Text to System-Text. 5. File in CUIS new classes: Editor, SimpleEditor, TextEditor and SmalltalkEditor. 6. Removed Collections-Text category.
Problems started here:
7. Merge CUIS Text class with Pharo Text class.
(Cuis) Text has an attribute named initialStyle not present in (Pharo) Text. This is the main diff from both images.
8. Merge CUIS NewParagraph with Pharo NewParagraph
(Pharo) NewParagraph has an attribute named textStyle not present in (Cuis) Pharo.
In several NewParagraph methods CUIS doesn't care is some strings are isOctetString, and the Pharo NewParagraph does. For example #composeAll. I've preserved the Pharo behavior.
Maybe i should start with the Squeak port then?
yes
Further steps:
9. Merge (cuis) TextMorph and (pharo) TextMorph, making it have a non-smalltalk,TextEditor.
10. Create (pharo) CodeMorph, replacing a TextMorph with a SmalltalkEditor. To my opinion , this will the major contribution, separating TextEditor and SmalltlakEditor concernes and their proper views , TextMorph and CodeMorph.
Fernando
On Jan 10, 2010, at 10:43 PM, Stéphane Ducasse wrote:
Excellent fernando! Did you start from squeak or cuis I was planning to start from Squeak since they ported back CUIS code in the context of WideStrings (CUIS is pre unicode support)
Stef
Juan re-factored the smalltalk behavior in the editors, creating the following hierarchy
Editor TextEditor SimpleEditor SmalltalkEditor
See the comment in Editor class in Cuis image http://www.jvuletich.org/Cuis/Index.html.
New text editors. TextEditor provides most of the functionality that used to be in TextMorphEditor. This class is no longer a Controller!
SmalltalkEditor is has Smalltalk code specific features.
SimpleEditor provides basic functionality for single line text editing. It does not handle fonts and styles, aligning and Smalltalk utilities. It handles one single line.
Would be nice to adopt this refactoring into Pharo, i've started to port it and cleaning up the textmorph in the process. But it's still a work in progress.
Fernando
On Jan 10, 2010, at 3:09 PM, Tudor Girba wrote:
Hi,
Gary and others
I really think that we should do an audit of Morphic. In 1.1 we are going already faster but I'm sure that there is plenty of space for improvements.
I see several actions - checking squeak toolbuilder enhancements and using it for the tools
- checking CUIS - juan did an excellent job remocving a lot of unnecessary code - juan optimize scrollbar - juan did a new texteditor morph
Indeed, a text editor that does not hardcode smalltalk specific behavior would be great :).
- removing/cleaning extra widgets Pluggable/nonpluggable plague. - integrating better polymorph into the widgets layer.
What do you think?
Doru
-- www.tudorgirba.com
"Reasonable is what we are accustomed with."
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project