Hi Mariano,
From a cursory look, it seems that it would be enough. I'll try to find some time next week to make a version that works using this infrastructure.
Cheers, Romain On Jan 16, 2010, at 11:43 AM, Mariano Martinez Peck wrote:
Hi guys: Of course I would like having keymapper or similar working in Pharo, but as I always say, I rather go step by step.
Last night, I was up to 2 am trying to get this working. I was almost there, but as I don't know everything about Morphic, I ask to you.
What Simon said about the binary changeset of Algernon, is true. However, I took the time to analyze the changeset and from my point of view (nil knowledge in Morphic) it seemed a very good change. I fix it (it has underscore assignment) and I was easily merged to Pharo. No conflicts. The main change does the simplest modifications to HandMorph for it to support various focus holders. And I think this is cool.
So, suppose we integrate this changeset, Algernon, wouldn't have any override the method sendKeyboardEvent:
Now Romain, do you think that you can manage to get WorkingSet working with this change without overriding? Algernon does, so maybe we can see how it do it. I saw this: Algernon >> registerWithSystem
There you will see it does a self activeHand addAdditionalKeyboardFocus: self.
That method was part of the Morphic changes.
I commit the Mprhic changes in http://www.squeaksource.com/MarianoPhD
Name: Morphic-MarianoMartinezPeck.396 Author: MarianoMartinezPeck Time: 16 January 2010, 3:42:18 pm UUID: 3587e1b2-36b4-4751-bcdb-ca6f4073788e Ancestors: Morphic-MarianoMartinezPeck.395
Romain, can you take a look and if this is not enough, how can we solve easily this problem in Pharo?
Thanks
Mariano
2010/1/15 Simon Denier <Simon.Denier@inria.fr>
On 15 janv. 2010, at 23:03, Mariano Martinez Peck wrote:
2010/1/15 Simon Denier <Simon.Denier@inria.fr>
On 15 janv. 2010, at 21:20, Mariano Martinez Peck wrote:
On Fri, Jan 15, 2010 at 5:55 PM, Romain Robbes <romain.robbes@gmail.com> wrote: yes it has overrides ...
that's because as far as I know, there's no keyboard shortcut management facility in Pharo. If there was one, I suppose Algernon and WorkingSet would coexist.
So...all your overrides are due to the shortcuts? I think it is not fear to "forbid" a package to be included in a Dev image if we don't provide from the core a way to manage shortcuts. So:
1) Or we let this projects to be installed in the Dev image
2) We fix the problem with the shortcuts.
Romain: can you tell us where exactly the problem is ? maybe someone can give you a hand.
Taking a look at that, there are 2 overrides in WorkingSet
How did you detect that ?
Manually, using an extension-aware browser (O2Package, MC browse package, or the package environment) to detect extensions, then check history in the versions browser.
Impressive. You should be a detective :)
A few years ago, I was called the human debugger during a project :) Now I try to restrain from this kind of sessions though, it's time consuming.
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Romain Robbes http://www.inf.unisi.ch/phd/robbes