On 18.12.2010 12:08, Sven Van Caekenberghe wrote:
On 18 Dec 2010, at 11:30, Philippe Marschall wrote:
Benchmarks always are ;-)
[...]
Excellent writeup, once again.
I think / I'm pretty confident that the cleanup goes well, as long as Socket[Stream] respects its timeout (currently set at 10s for all streams, maybe 5s would be better for the server) and throws ConnectionTimedOut and ConnectionClosed exceptions reliably.
Doing
Smalltalk garbageCollect. Socket allInstances.
before and after the benchmarks shows no leaking.
But then again, the HTTP request parsing could be made more bullet proof. Adding a load balancer in front of Zn that also sanitizes requests would be a good idea for production setups.
Yeah, in AJP I could save a lot of code because there's an Apache in front of it sanitizing the requests and managing the connections. Cheers Philippe