In defence to the author, i could say, that sometimes its really hard to follow KISS principle, especially when problem domain requires many conditions to be checked and hence you inevitably need to introduce branches in code. Sometimes, when code start stinking you can look back at model and find the way to simplify it, but sometimes you simply can't do that (consider bussiness logic ) :) And of course, for a novice programmer it is crucial to have a master, who can revise his code and teach how to write a good code, point at mistakes and so on.. Even not for novice, even i prefer to have someone who could revise my code, because in this way there are less chances that you miss something or doing awfully wrong unnoticed. 2009/11/10 Stéphane Ducasse <stephane.ducasse@inria.fr>:
On Nov 10, 2009, at 8:44 PM, John M McIntosh wrote:
On 2009-11-10, at 7:40 AM, Stéphane Ducasse wrote:
if you want to have fun try to identify the number of times certain parts are duplicated inside the same method.
Stef
Actually an interesting exercise here would be to determine who originally wrote the method, then decide is it a result of the author's original coding, or the result of 10 people hacking it.
If it's mostly the result of a single author, then I'm sure some nifty tool (someone could write) could determine which other methods the person authored then kick out the more complex ones and decide if the same coding practises are followed, er then mark them as candidates for simplification?
:) you know I found a fun one     self flag: #aname. "klhkjhjk"     self flag: #aname. "hkjkjhkj"
I mention this because it reminded me of a project I was on years ago where after a consultant had left we determined his code was problematic based on bug reports statistics and at 2:00 am one morning I and the senior project leader pressed *delete* on all that code base since we had decided it was cheaper to rewrite it all from scratch versus fixing it.
:)
Probably we should have done it several years ago but we are making progress daily.
Stef _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.