I tagged it as 1.5 ;) http://code.google.com/p/pharo/issues/detail?id=5456&thanks=5456&ts=13313066... On Fri, Mar 9, 2012 at 7:09 AM, Igor Stasenko <siguctua@gmail.com> wrote:
On 9 March 2012 04:28, Chris Cunningham <cunningham.cb@gmail.com> wrote:
On Thu, Mar 8, 2012 at 5:17 PM, Igor Stasenko <siguctua@gmail.com> wrote:
On 9 March 2012 01:22, Guillermo Polito <guillermopolito@gmail.com> wrote:
ClassBuilder>>validateClassName: aString ... self notify: aString asText allBold, ' already exists!\Proceed will store over it.'
Is it right to do that asText allBold there? :S Shouldn't an exception be raised instead?
Do I open a ticket?
Yes. We should kill dependency by removing asText asBold. Notifications should not accept rich-formatted text anyways, because not all ui managers can handle it (now we having command-line ui manager which prints message on console).
Maybe have the command-line ui manager dumb down the representation - I'm sure this isn't the only place.
Guille, this likely pre-dates Exceptions (or at least wide-spread use of them). A much better direction is to use exceptions (or Announcements?) here, and have a process capture them and display appropriately for what they can display. The mechanism should probably include Class name and exception text, which could be rich-formatted as above, or plain formatted for command-line UI, or interrogated for other observers.
if you replace it with exception, it doesn't means that exception should use text and bold.. so...
Just suggestions.
-Chris
-- Best regards, Igor Stasenko.