and looks like InputEventFetcher>>eventLoop contains syntax errors, a window variable shown in red color by my browser. :) 2008/11/22 Igor Stasenko <siguctua@gmail.com>:
2008/11/22 Igor Stasenko <siguctua@gmail.com>:
I just loaded your changeset and have something to report :)
It looks like it having bigger poll periods than old sensor, or works slower. An overall performance feels a bit more sluggish comparing to old implementation. Just open a window with long text and hold down the up/down key and see the difference. Or try to resize browser window - you can notice its not so smooth as in old image.
... which can be fixed easily by reducing poll period from 100ms to 10ms in InputEventPollingFetcher>>eventLoop
2008/11/22 Michael Rueger <m.rueger@acm.org>:
Stéphane Ducasse wrote:
so how do we proceed? We try to load it, play with it then? integrate it into pharo and you continue hacking and fixing?
this version is really meant to be smoke tested, it needs some work on the comments and on the user interrupt handling.
So please load it into your images, make sure you always have backups and see how it holds up. If it turns out to be reasonably stable we can push it.
1- Here I have a question =================== in this comment EventSensor = InputEventSensor?
the comment is only a copy from EventSensor, needs to be rewritten. If somebody has a better suggestion for naming this class I'm open to suggestions.
2- I saw a method defined on Controller But there are no reference to this class in pharo. So we could remove Controller I imagine
It is superclass of other classes, so I'm not sure.
3- could you tell me what kind of code we would have to change?
Not sure what you mean? For now no code in the image needs to be changed.
Michael
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.