On 12 October 2010 14:25, Henrik Johansen <henrik.s.johansen@veloxit.no> wrote:
On Oct 11, 2010, at 10:17 18PM, Igor Stasenko wrote:
On 11 October 2010 22:49, Schwab,Wilhelm K <bschwab@anest.ufl.edu> wrote:
Sig,
The most important words in there are "critical section." Â Carry on :)
Oh, please. This is not too hard to code.
My mind rolling around following choice(s) Â (there may be others i don't see). What would be a proper way to handle error during #finalize.
[ executor finalize ] on: Error do: [:ex |  self handleFinalizationError: ex  "where self is registry" ].
or:
[ executor finalize ] on: Error do: [:ex | Â executor handleFinalizationError: ex ].
of course, i should catch this error in test, so i can verify that:
a) test is get notified upon synthetically made error b) no matter what i do inside error handler (up to 'Processor activeProcess terminate'), a finalization process continues working (or restarts without losing remainder of executors).
I agree it should be the executor doing handling. However, if you get to this point, the executor already had the chance to do so in the finalize method itself, so I don't really see the point of sending it back..
well, its easier to add a default error handler in Object class, so any executor will have a default handler, and then some specific one may choose to override it, without putting a boilerplate of [ ] on: .. do: [] in every #finalize method. Besides, its natural , when you writing a code, you always expect that it will work w/o errors, and even if it fails, then in some concrete place, which means you usually not wrapping whole thing with exception handler. This leaves a chance to make another mistakes, like 'hey, despite i put error handler in my #finalize, something is still hangs finalization process'.
Personally, I feel the only promises FinalizationRegistry should make wrt. to errors during finalization, is it should never lead to: - termination of the (or a) finalization process, - discarding another finalization action.
Yes this is the main intent.
IE I am perfectly fine with an error here being thrown in your face (hopefully in a somewhat debuggable way, unlike what happened in your first example when removing the error-swallowing), as you've already passed the point a correction should be made, and there's nothing more intelligible to do than making sure everything keeps working, and inform of the error.
(Pretty sure the error swallowing was a quick hack for keeping everything working in the first place ;) )
What i like in doing #finalize in forked process, that it doesn't matter where you screwed up: in finalization code or even in error handling code, you still don't have a chance to damage the system. And moreover, you can open debugger and debug it. Spice must flooow :)
Cheers, Henry _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.