On 27 Jun 2017, at 15:57, Serge Stinckwich <serge.stinckwich@gmail.com> wrote:
On Mon, Jun 26, 2017 at 12:14 PM, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:
Hi,
this mail describes how to start to send pull requests to Pharo 7 Github repository from Pharo 7.
Thank you for the great explanation Pavel.
Preparations =====================
- you need to have a Github account and set SSH keys. See https://help.github.com/articles/connecting-to-github-with-ssh/ - create own pharo-project/pharo repository fork. Go to https://github.com/pharo-project/pharo, click on "Fork" button and follow the instructions
[ ... ]
Issue processing =====================
- create new case on FogBugz to get the issue number - open Iceberg and from the context menu on the 'pharo' repository do: Pharo - Create new branch from FogBugz issue, enter the issue ID and it will fill the full branch name for you - create your changes (you can do it before the creation of the branch too) - commit and push your changes in Iceberg, this way you will commit your branch to your fork repository. Remember that the Iceberg commit window has two buttons, one for local commit, the second for commit with immediate push. They can be very long because they contain the full branch (issue) name - in Iceberg in the 'pharo' repository context menu do: Pharo - Create pull request, fill your - fill your Github credentials - leave the PR title, comment is not required, check the pull request head and base. The base MUST be pharo-project/pharo development. Create the pull requests - go to https://github.com/pharo-project/pharo/pulls, check your pull requests and put URL of it into the issue record on FogBugz (as a comment). Resolve the issue as Fix review needed
It means, there is no PR without a corresponding FogBugz issue ?
it should not. same as before with SLICEs, there was no slice without issue :) Esteban
Regards, -- Serge Stinckwich UCN & UMI UMMISCO 209 (IRD/UPMC) Every DSL ends up being Smalltalk http://www.doesnotunderstand.org/