You can try with the attached patches. That should put the comments inside the cascade. Since there are no tests for this new behavior (it doesn't break any of the existing ones) I am reluctant of including them right away. It could well be that with these patches in some edge cases comments are lost or suddenly appear twice. Lukas On 1 March 2010 19:32, Lukas Renggli <renggli@gmail.com> wrote:
Excellent, thanks for the test case. I will have a look as soon as I get home.
Lukas
On Monday, March 1, 2010, Schwab,Wilhelm K <bschwab@anest.ufl.edu> wrote:
Lukas,
File in the attached and then reformat it. Â I have to admit there has been improvement; at least the comments remain within the cascade of which they were originally a part. Â Still, they end up out of order with respect to the reformatted code, which is devastating to what I am trying to accomplish. Â These are directly analogous to the types of comments that sat (in longer cascades) for several years only to save my back side last year.
Bill
________________________________________ From: pharo-project-bounces@lists.gforge.inria.fr [pharo-project-bounces@lists.gforge.inria.fr] On Behalf Of Lukas Renggli [renggli@gmail.com] Sent: Monday, March 01, 2010 7:47 AM To: Pharo-project@lists.gforge.inria.fr Subject: Re: [Pharo-project] about code formatting in pharo
I'm not complaining; it's simply a fact, and I'm not the only one observing it. Â Links were given here some time back.
Sorry, but this is only a fact if you provide unit tests (or at least a couple of examples) that fail in the latest code base. Otherwise simply nobody cares.
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
-- Lukas Renggli http://www.lukas-renggli.ch