I agree with you, it is too dirty solution. The next try: https://pharo.fogbugz.com/f/cases/20506/Fix-special-objects-array Thank you for the pointers. Cheers, -- Pavel 2017-10-10 14:04 GMT+02:00 Guillermo Polito <guillermopolito@gmail.com>:
Hi Pavel,
I don't like this change.
First, there is no comment nor explanation why that is needed. This change is obscure, if we forget in a couple of months why that line of code is there we may - delete it unintentionally - or leave it forever and fear to clean it up because we do not understand it :(
Second, It looks that recreating the special objects array there, like that, means that it was not correctly created from the beginning. We should instead create it correctly from the beginning.
I think we should revert this change.
On Tue, Oct 10, 2017 at 12:24 PM, <ci-pharo-ci-jenkins2@inria.fr> wrote:
There is a new Pharo build available!
The status of the build #176 was: SUCCESS.
The Pull Request #336 was integrated: "20505-The-special-objects-arr ay-needs-to-be-recreated-during-bootstrap" Pull request url: https://github.com/pharo-project/pharo/pull/336
Issue Url: https://pharo.fogbugz.com/f/cases/20505 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20p ull%20request%20and%20branch%20Pipeline/job/development/176/
--
Guille Polito
Research Engineer
Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>*
*Web:* *http://guillep.github.io* <http://guillep.github.io>
*Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013>