On a related topic, isValid looks to me like it could use some disambiguation... At the moment, as far as I can see, the implementors could imply the receiver is any of the below: - a valid method name - a valid method reference - a valid socket - a valid action - a valid MC repository - a valid connection queue Henrik Johansen wrote:
Found a solution to make it work in Pharo: The three messages createCloseBoxFor: createCollapseBoxFor: createExpandBoxFor: in UIThemeVistary needs the block argument of addUpAction: in each replaced by: (MessageSend receiver: aSystemWindow selector: #correspondingMethodInBlock).
(If changing Polymorph isn't the right thing to do, BlockContext needs to conform to the same protocol as MessageSend, it seems like)
Cheers, Henry
Henrik Johansen wrote:
Yes. It seems related to a Pharo fix, overrides in Polymorph packages weren't loaded in 101, but they are in 144. One of these overrides include SystemWindow>>createCollapseBox to make the theme handle how it should be created, in the vistary look this method (createCollapseBoxFor: ) calls addUpAction: of MultistateButtonMorph with a block as argument, which somehow gets added to a WeakActionSequence (I'm not familiar with neither squeak nor morphic really). This causes an MNU since the block does not respond to isValid used by the Sequence to clean up it's items.
I've not really dabbled much in Squeak nor Morphic, seems to me there's three alternatives: 1. - Bug in Polymorph (a block shouldn't be allowed as an action, sounds weird though) 2. - Overly zealous cleansing of methods (removal of isValid for blocks) 3. -A messy implementation of ActionSequence requiring isValid methods spread everywhere.
Henry
Stéphane Ducasse wrote:
Hi henrik
thanks for the report. Is the vistary look broken in 144?
Stef
On Nov 11, 2008, at 3:11 PM, Henrik Johansen wrote:
I've loaded Polymorph successfully (following the instructions at http://wiki.squeak.org/squeak/6005, the basicLoad override seems to be mandatory) quite a few time in the released dev images. TaskbarIcons can not be loaded without a proceed, since it includes an icon for PackagePaneBrowser, which is not in the pharo dev image. Vistary look is also broken due to a MNU, worked in 101, but broke somewhere before133 when I tried loading it next. Latest I've done it with is the 142 dev image, updated to 144 before loading Polymorph.
Cheers, Henry
Stéphane Ducasse wrote:
I hope :) we want it in the first version of pharo :)
Stef
On Nov 11, 2008, at 1:45 PM, Igor Stasenko wrote:
2008/11/11 Gary Chambers <gazzaguru2@btinternet.com>:
Polymorph fixed the menu gradient oddity a long time ago... :-)
btw, can it be loaded into dev image w/o problems? I'm missing the taskbar, because when you open many browsers overlapping each other, its hard to find needed one.
Regards, Gary.
----- Original Message ----- From: "Igor Stasenko" <siguctua@gmail.com> To: "Pharo Development" <pharo-project@lists.gforge.inria.fr> Sent: Monday, November 10, 2008 6:08 PM Subject: Re: [Pharo-project] New pharo-dev based on latest version
Some of my observations of glitches found:
- open world menu System->About. Now instead of clicking Ok, try drag the window. Leads to DNU when you release a mouse button.
- a submenu gradient in OB (maybe not only in OB) is sporadically loses its colors: when you first open a context menu, and first open a submenu in it, all is drawn ok. But then try hover over different menu items to force hiding/showing submenus, you will notice that newly opened submenus start losing gradient background, until finally background becomes completely white.
2008/11/10 Damien Cassou <damien.cassou@gmail.com>:
http://gforge.inria.fr/frs/download.php/10931/pharo0.1-10142dev08.11.2.zip
always available at: http://code.google.com/p/pharo/wiki/Downloads?tm=2
-- Damien Cassou http://damiencassou.seasidehosting.st
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project