16883 <https://pharo.fogbugz.com/f/cases/16883/Highlight-in-Senders-of-throws-a-MNU-if-the-search-term-was-found-in-a-class-comment>Highlight in Senders of... throws a MNU if the search term was found in a class comment <https://pharo.fogbugz.com/f/cases/16883/Highlight-in-Senders-of-throws-a-MNU...> 2015-10-28 16:19 GMT+01:00 stepharo <stepharo@free.fr>:
I see this is annoying that comments are not polymorphic.
yes, but comments are text and methods are code ....
Stef
Le 28/10/15 11:05, Nicolai Hess a écrit :
2015-10-28 15:33 GMT+01:00 stepharo <stepharo@free.fr>:
Hi
I typed 'Take' and source code with it. - the progress bar does not update
- more important when I click on the message browser I get a DNU ast
autoSelect: aSelector textModel readSelectionBlock: [ :text | self selectedMessage ifNotNil: [ :msg | (self sourceIntervalOf: aSelector in: msg ast) ^^^^^^^^^^^^^ ifEmpty:[ self searchedString: aSelector asString in: text ] ]]
and RGCommentDefinition does not understand ast. So what do we do?
It is a know bug ( at least, I know of it :) ) I changed the way the MessageBrowser selects the search term, because it always highlights the search term by "text" and not by "code" ,for example, in a "at:put:" senders MessageBrowser the first the highlighting started at the first at: although this is part of a at:ifAbsent: - message.
at: #OneShotArmed ifAbsent: [ true ]) ifTrue: [ Smalltalk globals at: #OneShotArmed put:
16673 <https://pharo.fogbugz.com/f/cases/16673/Senders-of-highlights-wrong-code-seg...> Senders of... highlights wrong code segment
But I didn't take the "class-comment"-search results into account.
Is it a well know bug?
Stef