I merged them also in PharoTaskForces On Jan 28, 2011, at 12:02 AM, Dale Henrichs wrote:
On 01/27/2011 03:00 PM, Lukas Renggli wrote:
I started to merge some of your changes to FS.
I already merged most of the changes of Max into the main code.
Now I was wondering about this one: ***for my work on GitFS I needed a resumable exception (alternatively an ifPresent block would have done the trick but that would have ment more meddling with Filesystem) to delete existing files when copying. The following changes are a result of introducing this exception to the copy methods. *added class FSFileExistsResumbale and its superclass FSFilesystemException to support the changes to the copy methods *#copy:to: signals FSFileExistsResumbale instead of FSFileExists *FSCopyVisitor>>copyDirectory uses #ensureDirectory instead of #createDirectory *needed to change FSFilesystemTest>>testCopyDestExists to expect FSFileExistsResumable *FSReference>>basicCopyTo: signals FSFileExistsResumable instead of FSFileExists
Could you explain us a bit more?
This is not something that should go into the main code. If I remember correctly this was a quick hack to avoid some problems in GitFS.
Lukas
At the time I ported FileSystem to GemStone (4 months ago?), I started with the packages in Lukas' repository...
Dale