On Aug 30, 2010, at 1:25 PM, jaayer wrote:
---- On Mon, 30 Aug 2010 03:32:18 -0700 Stéphane Ducasse wrote ----
+1 So this is ok :) What I would love in my wildest dream is to have magnitude using TComparable :) But this may be too complex. I would like to have the time to check how we can make trait implementation leaner, smaller.....
Stef
Actually, if you change Magnitude's class definition to this:
Object subclass: #Magnitude uses: TComparable instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Kernel-Numbers'
and then manually remove its "comparing" and "testing" messages, everything seems to work. (Same number of passed/failed tests in "KernelTests-Numbers" as before ) But I could see this potentially causing build issues.
Excellent!!!!! I would not have dare doing it. We are trying to get the system bootstrap and bumping in a lot of issues and shaking the system. So I was implying more that. I'm also thorn apart about the pluggability of traits - my meta sin. :) http://code.google.com/p/pharo/issues/detail?id=2884
Also, Magnitude's "testing" messages, despite what their category name implies, do not return booleans; instead they return other Magnitudes. I have recategorized those messages (#min:, #max:, and #min:max:) in TComparable under "comparing" in the attached fileout.<TComparable2.st>_______________________________________________
Indeed http://code.google.com/p/pharo/issues/detail?id=2882
Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project