2009/10/19 Miguel Enrique Cobá Martinez <miguel.coba@gmail.com>
El lun, 19-10-2009 a las 12:47 -0200, Mariano Martinez Peck escribió:
2009/10/19 Miguel Enrique Cobá Martinez <miguel.coba@gmail.com> El lun, 19-10-2009 a las 11:58 -0200, Mariano Martinez Peck escribió: > > > On Mon, Oct 19, 2009 at 10:59 AM, Adrian Lienhard <adi@netstyle.ch> > wrote: > 10483 - 10487 > ----- > - Issue 1310: Make all tests green > > This is grate news. Sorry for my ignorance, but when you refer to "all > tests" are you talking about Pharo core or just Pharo? In addition, is > a Pharo goal to have also all test green in the dev image ?
I don't think so. The packages added by the dev images are independent and their tests are their own responsibility.
I am sorry but I am not totally agree. Pharo core is something internal. Imagine a final user who just go to www.pharo-project.com/download and he downloads the "Pharo image". He will expect to have all green tests. He won't be aware of pharo core at all.
I agree from a user perspective. But the dev images are, I think, a community bonus resulting from the effort of Damien.
He isn't and musn't
be responsible for checking if the packages included have green tests or not. Even more, the fact that a package hasn't green test doesn't necessarily means that the package is broken. It could mean that the tests aren't updated to the current package code. The package could very well work correctly although some tests fail.
So, yes it *would* be great to have the dev packages all with green tests but this is almost impossible to get with the current workforce and free time.
Great but almost impossible.
I am agree. But, tests have several purposes. One of them is to try to build robust software. So, the final users will use Pharo, not Pharo core. So, if Pharo has a lot of red tests and it is buggy, it won't be usable from a user perspective, no matter how core is. It's like, who cares if Ubuntu kernel works well if what I use is Ubuntu? I need ubuntu to be robust, which includes ubuntu packages and core. What I propose is to identify the red tests of Pharo dev and look for the package and ask the maintainers (if there is anyone) to fix it. And the regarding tests, we can tag them as 1.1
Cheers
Moreover, if packages are included in Pharo dev it is because it is a Pharo decision. So, if pharo thinks that, for example, ocompletion must be in Pharo, so, I think that ocompletion tests must be green.
But I don't think that the package lists (web and dev images) are blessed by the Pharo board.
And I am not agree with this also. I think Pharo board, and even the community has to choose the Pharo packages. Please, take in mind that the final users will use and see Pharo, NOT PHARO CORE.
I don't say it is Pharo responsability to have those tests in green.
Again, I am not saying it is Pharo responability to do this. This was a BIG step in Pharo.
> > - Issue 1330: Better performance for tests > > Test result: 7168 run, 7150 passes, 18 expected failures, 0 > failures, > 0 errors, 0 unexpected passes > > ___________________ > http://www.adrian-lienhard.ch/ > > > _______________________________________________ > Pharo-project mailing list > Pharo-project@lists.gforge.inria.fr >
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
> > _______________________________________________ > Pharo-project mailing list > Pharo-project@lists.gforge.inria.fr >
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Miguel Cobá http://miguel.leugim.com.mx
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Miguel Cobá http://miguel.leugim.com.mx
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project