Hi Stef, Publishing diffs to the mailing list certainly works great for Squeak. Squeak's commit rate is rather less than Pharo's, so it might be too much... but the easiest way to find that out is just switching the diff publishing on and seeing how people feel. frank On 20 March 2013 20:40, stephane ducasse <stephane.ducasse@free.fr> wrote:
Hello nicolas
I know what you think about seeing code changes. So what can we do to improve it. I'm in favor to send diff to the mailing-lists especially since SmalltalkHub will support the charge now.
Stef
Totally agree, but for this specific bug I think that the process can be improved by increased code reviews. The fact that a negative seconds inst var and a julianDayNumber inst var different from julianDayNumber message was chosen indicates that current implementation is a quick hack, a workaround for solving some problems, but clearly not a long term solution. IMO it creates as many problems as it solves. Diff has been added lately, and it is a real progress for reviewing code, but the effort to participate is still a bit high. More eyes, more reviews...
The fact that bug only show up around midnight is true only for Europeans which have small offsets from UTC, I guess the probability of bug shall increase in California or Japan.
Nicolas