On Fri, Jun 29, 2018 at 5:54 PM Clément Bera <bera.clement@gmail.com> wrote:
Hi,
Normally the pull request should break the exception tests, especially the ones with nested handler, since they are the reason 199 marked signalling contexts were introduced
Yes, but it's ok that on:do: is marked but why evaluateSignal:? Do you know?
.
Looking quickly this test in latest Pharo 7 for example: ExceptionTests>>testHandlerContext fails with the pull request.
Since the pull request changes a green test into a red test, I don't understand why you say "we unfortunately don't have tests for it".
Because I haven't see those. I was looking for tests about #findNextHandlerContext, #findNextHandlerOrSignalingContext and I found nothing. But if we have some tests much better!
I don't understand either why you say this pragma is "wrong", so I can't help with that either.
Well, I don't know if I have to repeat myself... This is apparently provoking the infinite debugger issue. This pragma was not there in Pharo3, and its not clear why a method that is not an exception handler is marked as an exception handler. Is that clear enough? For more info you can read the issue.
Best,
On Fri, Jun 29, 2018 at 4:48 PM, Guillermo Polito < guillermopolito@gmail.com> wrote:
Hi all,
during today's sprint we have been working with lots of people on the infinite debugger problem (https://pharo.fogbugz.com/f/cases/22085/). We have checked the emails sent in the latest month. Then, together with Quentin, Pablo, Pavel, Yoan we have been discussing and testing hypothesis all day. We have been also comparing the debuggers code between pharo 3/4 (where the bug was is present) and pharo 7, but this was not necessarily straight forward as the code is not the same and there is no easy diff...
AAAAND, we have found that the problem may come from a wrong pragma marker. Just removing that pragma gives us back the same behaviour as in Pharo 3/4. :D
https://github.com/pharo-project/pharo/pull/1621
I know that the exception handling/debugging has been modified several times in the latest years (some refactorings, hiding contexts...), we unfortunately don't have tests for it, so I'd like some more pair of eyes on it. Ben, Martin could you take a look?
Thanks all for the fish, Guille
-- Clément Béra https://clementbera.github.io/ https://clementbera.wordpress.com/
-- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13