Hi, On Fri, Apr 3, 2015 at 10:56 AM, Ben Coman <btc@openinworld.com> wrote:
I've just started trying to make more use of the code pane in Spotter. It seemed ideal for the case when I want to add "self haltOnce" to a dozen methods. However when I hit <enter> to get a new line, Spotter closes.
Additionally the Browser that opens doesn't contain the change I made in Spotter - they've been thrown away.
I propose that when the cursor is inside the code pane, it doesn't close Spotter. Even at this late stage, could this be done for Pharo 4? Only because I am guessing this since Spotter is a core tool, this might end up a common complaint as people adapt their workflow to use Spotter more.
Spotter is primarily a search tool that has no modes. Editing in place is certainly an important use case, but we should not treat it lightly. For example, Enter is the keybinding for triggering the default action on the selected item. Allowing the editor to take precedence in handling it will introduce a mode and this will change the core of Spotter. And there is something else. Right now, the editor shows you the whole method including the signature because that is the default. What happens when I change the name of the method in the preview? This would require updating the search list, which is not a use case Spotter is made for at this point. All in all, I would not add this support now, because it requires more thinking.
Would it be safer at this late stage prior to Release that this be done as a Slice, to limit other changes that might come through the Spotter Configuration?
There will be another integration of GT before the release. Cheers, Doru
cheers -ben
-- www.tudorgirba.com "Every thing has its own flow"