On 10/28/16 2:07 AM, Guille Polito wrote:
Hi!
-------- Original Message --------
Guillermo,
Apparently you don't like the github browser-based code review tool?
What are your objections?
Do you know of a better tool that is out in the wild or do you just have visions that code review could be better?
Better tools are always possible, but it is sometimes nice to use a tool that you didn't have to build from scratch while creating the better tool:)
Well, that is in fact my point. I'd like to know options and alternatives. If the easiest to setup and use is github's one, ok, that's no problem to me. Following the github workflow model is probably best for getting started ... just because it is well documented and directly supported by the guthub tools ... as a community, we need to make a shift to this new model (for some) and keeping it simple is good ... over time the github workflow has evolved and tools like the ones Phil was talking about have come into play (for good reasons) but shifting a community process is hard enough ... individual developers have the freedom to set up their projects on gitlab or bitbucket ... but for Pharo kernel adopting the github tools and workflow (in the beginning) makes a lot of sense ..
What bothers me the most from the github+filetree combination when reviewing a pull request, is that it is a file-based review. And finally you're reviewing the low-level export format, and I get a bit lost... Just dreaming, maybe there is some tool out there where we can just provide a kind of plugin to enhance the review? I mentioned in another thread that I would like to see an amber (or PharoJS) based github filetree browser that allowed one to browse the project code in a familiar Smalltalk browser ... I assume that a project diff browser could be done as well --- I think the web api for github is pretty sophisticated so these kinds of tools would be possible ... I'd think
But for sure I do not want to do one from scratch :) Haha, yeah ... I've got an amber-based repository viewer that I use on my github.io page .. and it comes complete with a MNU and a debugger ... I would fix the bug, but I think that the having the debugger come is kind of nice ... in a twisted sort of way:) Dale
[1] http://dalehenrich.github.io/
Dale
On 10/27/2016 05:06 AM, Guillermo Polito wrote:
I would like to have a good code review tool, before having to do one ad-hoc...
On Thu, Oct 27, 2016 at 1:50 PM, Denis Kudriashov <dionisiydk@gmail.com <mailto:dionisiydk@gmail.com>> wrote:
Hi.
With future transition to github I ask myself what tools we will have out of the box. I google a bit and found these nice service http://ghv.artzub.com. Try to search guillep and then pharo-core. It looks really nice.
What other online services you know to analyse github projects?