I also fail to see why this is soo bad. The plugin passes settings to another object. The plugin is Mac only, from 200 years ago. Yes, we would try to do things different today, but the outside world is messy.
On 12 Mar 2015, at 06:58, Marcus Denker <marcus.denker@inria.fr> wrote:
On 12 Mar 2015, at 03:38, Sean P. DeNigris <sean@clipperadams.com> wrote:
Guillermo Polito wrote
Smalltalk os isMacOS ifTrue: [ self useHTTPProxy ifTrue: [ (self getHTTPProxyHost findTokens: ':') ifNotEmpty: [ :p | NetworkSystemSettings httpProxyServer: p first; httpProxyPort: p second asInteger; useHTTPProxy: true ] ] ifFalse: [ NetworkSystemSettings useHTTPProxy: false ] ]
Oh god, why?! Why?!
I harvested the class (the plugin was shipped with the VM already) for Squeak against the *explicit* wish of Andreas (because one could do better, which of course never happened⦠Squeak in itâs essenceâ¦)
So: I wanted to make sure that it did not brake anything⦠so I added a very conservative check to only end up calling it on the mac, with as little impact as possible.
Marcus