On 18 Nov 2015, at 5:20 , Nicolai Hess <nicolaihess@gmail.com> wrote:
2015-11-18 13:53 GMT+01:00 Mariano Martinez Peck <marianopeck@gmail.com <mailto:marianopeck@gmail.com>>: Thanks Nicolai. Our monkey say it was success :) Do you think Marcus should review it? or you confident enough?
A review would be good :)
How about you, Henrik? This is an interesting bug :-)
My initial though was "Why can't we just pop the copied vars from the stack *after* the block creation, instead of before, when they're part of the closures stack depth?", but didn't have the time to actually understand how it works/why that would be wrong... So I'll trust your judgement on this. To bikeshed, I would have preferred stack pop: anAmount to anAmount timesRepeat: [stack pop] though. ;) Cheers, Henry