I think Tudor is right. We cannot have shout everywhere by default. Take an example. Today morning, I opened the latest PharoDev and I couldn't understand why my nice welcome workspace was converted to an ugly red text workspace, like if it was code, which was not, of course. Now I read this email and I think it is related. Take a look to the PharoDev image from hudson and you will see what I am talking about. +1 not having Shout for everybody and instead, have the previous behavior. Of course I have no idea how to do it because otherwise I would have done it. Now, if we change to what Doru says, so I think some senders have to be updated if they would expect to have shout as the default. For example, FinderUI. I guess it would like to use the default/null styler in a PharoCore image, but in presence of Shout, it would probably like to use shout styler. But in such case, maybe he can use #styler: rather that #setDefaultStyler ? cheers mariano On Sun, Jan 23, 2011 at 8:47 AM, Marcus Denker <marcus.denker@inria.fr>wrote:
Hi,
We need the imperfect, intermediate solution that is good enough for people to live with in 1.2.
On Jan 22, 2011, at 4:25 PM, Tudor Girba wrote:
Hi,
In the latest Morphic version, the default styler of the PluggableTextMorph is given by: useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do"
Smalltalk globals at: #SHTextStylerST80 ifPresent: [ :stylerClass | self styler: (stylerClass new view: self) ] ifAbsent: [ self styler: ( NullTextStyler new view: self) ]
Thus, if Shout is loaded, you will get it in all text morphs by default. Given that TextMorph should be general and be used in all sorts of contexts, the default behavior should be the original:
useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do"
self styler: (NullTextStyler new view: self; yourself).
What do you say?
Cheers, Doru
-- www.tudorgirba.com
"We are all great at making mistakes."
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.