On Nov 22, 2012 11:23 PM, "Igor Stasenko" <siguctua@gmail.com> wrote:
On 22 November 2012 20:22, Ciprian Teodorov <ciprian.teodorov@gmail.com>
wrote:
Hi Igor,
My bet ... extracting the nbXAtOffset to the TNBMemoryAccessors broke the callbacks since I have also removed the ulongAt: and ulongAt:put: accessors which are used by the callback counter (there are some strange argument conversions going on).
Though if I merge your .78.mcz with my .83.mcz all tests pass ...
I don't know what you think about having the memory accessors in a trait? the bad thing is that I do not see any way of sharing them with the ones from ByteArray (can we extend a class with traits?)...
hmm.. i think we can't because that will make Collections package dirty. So, there's not much choice: we should use only extension methods. What i thinking is getting rid of ulongAt/put protocols, and use uint32 instead to be more precise and to not confuse with C types. That's what I have tried to do in my last 3 commits, but there seems to be some strange border effect (with callback counter) that I did not see coming. I'll look into it during the WE.
Cheers
however such a trait might be handy if we want to implement something
like
FloatArray using NB (think about FloatArray32, FloatArray64, etc)...
I will try to fix this issue during the WE... if I will find the time.
Thanks very much! Ciprian
On Thu, Nov 22, 2012 at 2:49 PM, Igor Stasenko <siguctua@gmail.com> wrote:
i will check.
I didn't merged with your code, Ciprian yet.. does it crashing for NativeBoost-Core-IgorStasenko.78 or in your code?
i will merge your stuff and check.
-- Best regards, Igor Stasenko.
-- Dr. Ciprian TEODOROV Ingénieur Développement CAO
tél : 06 08 54 73 48 mail : ciprian.teodorov@gmail.com www.teodorov.ro
-- Best regards, Igor Stasenko.