but that's with the "old new implementation" in the "new new implementation", TestFoo in "Test-Foo-Bar" will produce: lookup? 'Tests-Foo-Bar' => success! lookup? 'Tests-Foo' => fail! lookup? 'Tests' => fail! but... RPackageSet ("Tests" or "Tests-Foo") lookup will succeed. That's why I asked you to wait... all changes you do now could have no sense or change tomorrow :) Esteban On Sep 11, 2012, at 4:47 PM, Camillo Bruni <camillobruni@gmail.com> wrote:
On 2012-09-11, at 16:41, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
camillo
what is "added hierarchical RPackage lookup" ? Why do we need that beast?
Because right now RPackageOrganizer does a wrong lookup for classes see RPackageOrganizer>>#systemClassRenamedActionFrom: which does a #packageNamed: class category which fails if the class is not in a toplevel package.
Let's say I refactor a class TestFoo in the category 'Tests-Foo-Bar' the message send to #packageNamed: will try to find a package named 'Tests-Foo-Bar' but the actual existing package is only 'Tests' and the rest is the tag part.
=> you have to find the RPackage with the most common name lookup? 'Tests-Foo-Bar' => fail! lookup? 'Tests-Foo' => fail! lookup? 'Tests' => success! 'Tests' => lookup tag? 'Foo-Bar' => success!