On 18 March 2011 18:39, Benjamin <benjamin.vanryseghem.pharo@gmail.com> wrote:
Hi lukas
with Stef we refactored the Browser environment:     - now it can be parametrized by a system dictionary     - we also move selectionIn* to the AST-Core so that Environment can be loaded independently.
Could you integrate the packages in rb?
No, please read the mail I sent this morning to the list. 1. 'BrowserEnvironment' is supposed to be *stateless*. BrowserEnvironment is supposed to *always* represent exactly the same thing. The only refactoring that would make sense is to extract all senders of 'Smalltalk globals' to a separate method so that subclasses could override it. 2. The change where you move code from 'Refactoring-Enviornment' to 'AST-Core' introduces a bad dependency. 'AST-Core' is at the lowest level, it should not depend on anything else. Ideally the dependency between 'Refactoring-Enviornment' to 'AST-Core' should be cut, but that would involve a third package. In other Smalltalks the code in question is packaged with the UI. Lukas -- Lukas Renggli www.lukas-renggli.ch