On 09/06/2018 16:43, Hilaire wrote:
Hi Cyril,
From what I read in an older P7 image DockingBarMorph>>defaultBorderWidth was not implemented, and inherited, from AlignmentMorph which defaultBorderWidth returns 0.
It was here but in a different hook. It was in setDefaultParameters as you can see here: https://github.com/pharo-project/pharo/pull/1479/files#diff-f9fc80b09f7cbc9c...
Next, why docking bar should have the same width as menu?
It was the previous behavior. What I changed is that now #themeChanged reset the border width to take the one of the current theme when before it was ignored.
The question is do we want docking bar to have border?
I'll probably propose a new method in the theme #dockingBarBorderWidth and we can return 0 by default for it.
I see the Playground tool bar is impacted, although it does not make is UI less suitable.
In the meantime I just set DockingBarMorph>>defaultBorderWidth to returns 0, so I can use the last build at school with students. By doing so I did not notice glitch..
I am not sure docking bar not having border should be considered as a bug..
Thanks
Hilaire
-- Cyril Ferlicot https://ferlicot.fr