https://pharo.fogbugz.com/f/cases/11627/prevent-completion-from-popping-out-... On 16 September 2013 17:50, Igor Stasenko <siguctua@gmail.com> wrote:
On 16 September 2013 17:43, Esteban Lorenzano <estebanlm@gmail.com> wrote:
do not lose your time trying to fix that. We are going to change it anyway.
but i don't want to wait till your changes will come, i want it now, so i will push the slice, and if you don't want it, just don't integrate :)
Esteban
On Sep 16, 2013, at 5:39 PM, Igor Stasenko <siguctua@gmail.com> wrote:
trying to fix completion autopopups when there is nothing to suggest to prevent popping up the empty and useless menu, i stumbled upon this:
initializeInstVars (clazz isNil or: [ includeVariables not ]) ifTrue: [ ^ self ]. instVars := clazz allInstVarNames asSortedCollection. instVars := instVars collect: [ :each | NECInstVarEntry contents: each type: #instVar ]. instVars add: (NECSelfEntry contents: 'self' type: #self). instVars add: (NECSuperEntry contents: 'super' type: #super)
there's something sick with that.. first we using NECSelfEntry but then, if that's not enough, we pass 'self' as its contents.. but that's also not enough! we pass 'self' as its type as well..
checking many subclasses of NECEntry and how they initialized, it is almost every time the same:
- you use NECXXXXEntry , we always pass separate #XXXX as its type like just using NECXXXXEntry not enough to indicate that.
i going to fix that as well
-- Best regards, Igor Stasenko.
-- Best regards, Igor Stasenko.
-- Best regards, Igor Stasenko.