Paul, On 16 Dec 2011, at 22:53, Paul DeBruicker wrote:
Hi -
Because of how Internet Explorer reports javascript dates back to Seaside (as detected by Brian Murphy-Dye when using the FullCalendar jQuery plugin) I added the ability to determine the timezone based on the abbreviation IE reports. I used the list here: https://en.wikipedia.org/wiki/Time_zone_abbreviations to create an expanded version of
TimeZone class>>#timeZones
which encompasses those shown in the list on wikipedia. And added some convenience methods.
Its not as useful or sophisticated as David Lewis's TimeZone database or Chronos, but its more than what's in the image now.
If someone wants it I can make an issue and package my changes up for review. Right now I'm just including them as extensions to the JQWidgetBox-JQFullCalendar-Core package.
Thanks for whatever guidance you care to provide.
Paul DeBruicker
I had a quick look at your code and it seems like a logical addition (given what TimeZone currently is and what you want to do: interpret tz abbreviations). I have 3 remarks/comments: - the list is currently a dynamic array that is recreated on every access, wouldn't a lazy initialized class variable be better ? - one other goal of a list of timezones is to present them to the user to pick one; for that TimeZone as it stands now is insufficient (there is no country/city mapping, which is the most user friendly way to pick one, IMHO). it seems a bit wastefull to have such a list and not be able to support that goal as well. - on Mac OS X and Linux, there is enough data in /usr/share/zoneinfo to dynamically load/parse from, if something equivalent existed on Windows, we could use that (and benefit from OS level updates to this DB); I know it is more work, I'm just thing out loud. Sven PS: there are very few users of TimeZone in the image ;-)