PluggableTextMorph>>#accept (sadly required defence against text setters that don't return a boolean) SystemWindow>>#mouseDown: (removed offending line, now obsolete, apparently) Regards, Gary ----- Original Message ----- From: "Stéphane Ducasse" <stephane.ducasse@inria.fr> To: "Pharo Development" <Pharo-project@lists.gforge.inria.fr> Sent: Saturday, February 14, 2009 3:23 PM Subject: [Pharo-project] unnecessary =, == :)
Check for a =, ==, ~=, or ~~ message being sent to true/false or with true/false as the argument. Many times these can be eliminated since their receivers are already booleans. For example, "anObject isFoo == false" could be replaced with "anObject isFoo not" if isFoo always returns a boolean. Sometimes variables might refer to true, false, and something else, but this is considered bad style since the variable has multiple types.
Project>>#setChangeSet: Project>>#isolationSet Project>>#compileAll:from: Project>>#writeFileNamed:fromDirectory:toServer: Project>>#isolationHead PNGReadWriter>>#debugging ClockMorph>>#addCustomMenuItems:hand: ClockMorph>>#step ClockMorph>>#toggleShowingSeconds ClockMorph>>#toggleShowing24hr WorldState>>#interCyclePause: Integer>>#quo: Integer>>#digitSubtract: SimpleServiceEntry>>#useLineAfter MorphicUIManager>>#interactiveParserFor: OBPluggableListMorph>>#mouseUp: PianoRollScoreMorph>>#addCustomMenuItems:hand: SystemDictionary>>#abandonSources SystemDictionary>>#internalizeSources SystemDictionary>>#internalizeChangeLog SetTest>>#testRemoveIfAbsent SimpleButtonDelayedMenuMorph>>#mouseUp: Installer>>#validate Installer>>#logErrorDuring: SketchEditorMorph>>#verifyState: SketchEditorMorph>>#deliverPainting:evt: SketchMorph>>#useInterpolation: Slider>>#descending JoystickMorph>>#autoCenterString JoystickMorph>>#button1 JoystickMorph>>#button2 SARInstaller>>#errorNoSuchMember: MessageSet>>#growable HandMorph>>#handleEvent: HandMorph>>#fullDrawOn: ImageSegment>>#declareAndPossiblyRename: PluggableListMorphPlus>>#wantsDroppedMorph:event: SUnitTest>>#testRanOnlyOnce BitmapFillStyle>>#isTiled InstallerMonticello>>#mcDetectFileBlock FTPClient>>#login Object>>#mustBeBooleanIn: Object>>#'~=' Decompiler>>#pushConstant: TextMorphForEditView>>#acceptOnCR HostSystemMenusMenuItem>>#shift FlapTab>>#inboard FlapTab>>#flapShowing FlapTab>>#tabSelected PluggableTreeMorph>>#wantsDroppedNode:on: DisplayScreen>>#deferUpdates: OBSystemBrowser>>#defaultBackgroundColor SmalltalkImage>>#setPlatformPreferences SmalltalkImage>>#snapshot:andQuit:embedded: URLMorph>>#mouseUp: MultiNewParagraph>>#multiComposeLinesFrom:to:delta:into:priorLines:atY: Collection>>#reject: TextDiffBuilder>>#hasMultipleMatches TrueTest>>#testNot TrueTest>>#testInMemory TrueTest>>#testAND MCFileBasedRepository>>#possiblyNewerVersionsOfAnyOf: Process>>#terminate ProtoObjectTest>>#testIsNil SqueakPage>>#write ColorPickerMorph>>#putUpFor:near: FalseTest>>#testAnd FalseTest>>#testOR FalseTest>>#testNot FalseTest>>#testAND UpdatingStringMorph>>#growable UpdatingStringMorph>>#autoAcceptOnFocusLoss LanguageEditor>>#selectedTranslationsAt:put: Socket>>#setOption:value: MultiCompositionScanner>>#setFont PositionableStream>>#unCommand HTTPSocket>>#logToTranscript Number>>#odd OBHierarchyBrowser>>#defaultBackgroundColor MorphExtension>>#isDefault MorphExtension>>#sortedPropertyNames MorphExtension>>#printOn: MorphExtension>>#hasProperty: ObjectOut>>#doesNotUnderstand: PluggableTextMorph>>#hasEditingConflicts PluggableTextMorph>>#accept SimpleSliderMorph>>#truncate OBProtocolBrowser>>#defaultBackgroundColor SystemWindow>>#mustNotClose SystemWindow>>#mouseDown: RBReadBeforeWrittenTester>>#read RBReadBeforeWrittenTester>>#processBlock: RBReadBeforeWrittenTester>>#processStatementNode: RBReadBeforeWrittenTester>>#processIfTrueIfFalse: GradientFillStyle>>#isRadialFill RefactoryTyper>>#typeFor: CompiledMethodTest>>#testValueWithReceiverArguments OBLazyListMorph>>#handleMouseMove: BlockContextTest>>#testSupplyAnswerThroughNestedBlocks BlockContextTest>>#testSupplyAnswerUsingTraditionalMatchOfQuestion BlockContextTest>>#testSupplySameAnswerToAllQuestions BlockContextTest>>#testSupplyAnswerUsingOnlySubstringOfQuestion BlockContextTest>>#testSupplySpecificAnswerToQuestion BlockContextTest>>#testSupplyAnswerUsingRegexMatchOfQuestion ImageMorph>>#isOpaque: ProjectSwikiServer>>#acceptsUploads PolygonMorph>>#rotateTestFlip: PolygonMorph>>#beStraightSegments PolygonMorph>>#beSmoothCurve BitBlt>>#drawFrom:to:withFirstPoint: FileList>>#getSelectedDirectory FileList>>#getSelectedFile RBParser>>#patchLiteralMessage OBMultipleSelectionColumn>>#listSelectionAt:put: ServerDirectory>>#upLoadProject:members:retry: MorphObjectOut>>#doesNotUnderstand: HaloMorph>>#addHandles ThumbnailImageMorph>>#togglePopupFeature ThumbnailImageMorph>>#handlesMouseDown: ThumbnailImageMorph>>#popupFeatureString ContextPart>>#jump:if: MCWorkingCopy>>#merge: FileDoesNotExistException>>#readOnly RBLiteralNodeTest>>#testValue Prefer...
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project