2015-03-05 14:33 GMT+01:00 stepharo <stepharo@free.fr>:
We can use text: I should put it back.
If so, hurry up! Torsten is about to remove all calls to #text: For example (and many more) : 15066 <https://pharo.fogbugz.com/default.asp?15066> InputWidget and DateModel should use #label: instead of deprecated #text:
the point is not that, the point is that each widget should expose its valueHolder and we should get rid of the when...changed: I was probably confused because the refactoring broke in the middle
Le 5/3/15 09:39, Nicolai Hess a écrit :
2015-03-04 14:00 GMT+01:00 Sean P. DeNigris <sean@clipperadams.com>:
What is the reason for this? I searched the lists & fogbugz for "labelmodel text" to no avail. To me, "label label: aString" seems odd. Why is this better than "label text: aString"?
I think the idea behind this was, one common api for all widgets with a label CheckBoxModel /RadioButtonModel /ButtonModel .... all have a label: method.
But of course, one can argue, a label itself has a text.
In general, for refactors like this, where the purpose is not obvious as it would be for a bug fix or new feature, it would be good to somehow link somewhere for more info. Maybe the deprecation message, since by definition will be deleted in the next verison, would be a good place to put an issue number or url to a discussion. Also, might I humbly suggest having a native English speaker review changes where the intent is to increase "clarity" so we don't have another #ensureCreateDirectory incident ;) j/k... But a grammar/idiom review would be super quick/easy. Maybe a tag or status in fogbugz would help?
----- Cheers, Sean -- View this message in context: http://forum.world.st/LabelModel-text-Deprecation-tp4809424.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.