On 12 Nov 2015, at 10:49, Sven Van Caekenberghe <sven@stfx.eu> wrote:
But how could Epicea have an impact on that part ?
That is the question.
Unless someone objects, I would not say that this should hold integration. There will be much more work to do after integration when people start using it ;-)
Unless #benchFor: is broken for everyone, everywhere, of course
On 12 Nov 2015, at 10:40, Martin Dias <tinchodias@gmail.com> wrote:
Hi Sven,
El 12/11/2015 9:32, "Sven Van Caekenberghe" <sven@stfx.eu> escribió: Hi Martin,
Here is the relevant issue for the last change in that method:
https://pharo.fogbugz.com/f/cases/14989/Improve-and-simplify-BlockClosure-be...
IIRC the timing change was done in Squeak too, not the BenchmarkResult object.
Maybe the old code is more reliable, thing is, the CI machines being VM's sometimes act very weird with respect to timing and clocks.
Thanks for the pointer, I like the improvements of that slice: using the fork instead of comparing on each run, the new API, the new object to model the benchmark.
Any suggestion of what to do with my problem? If I skip #testBenchFor, then no problem. So, it's the only test in the whole image that presents this problem.
Ah, and this happens locally in my Mac OS too, not only in the CI.
Martin