Hello, yes, this looks like a solution to me. Can you open an issue? Marcus
On 15 Oct 2015, at 13:01, Nicolai Hess <nicolaihess@web.de> wrote:
2015-10-15 9:36 GMT+02:00 Marcus Denker <marcus.denker@inria.fr <mailto:marcus.denker@inria.fr>>: Yes,
-> there is a bug somewhere that flattens traits in some cases
Any idea how to fix this?
I already provided a fix for the package fileout: ( 10808 Bad behavior on FileOut/FileIn tool when using traits)
But for Monticello packages, this works differently. A quick look at MCPackage>>#snapshot shows: .... rPackageSet methods do: [:ea | definitions add: ea asMCMethodDefinition] displayingProgress: [ :ea| 'Snapshotting methods...' ].
rPackageSet overriddenMethods do: [:ea | definitions add: (rPackageSet changeRecordForOverriddenMethod: ea) asMCMethodDefinition] displayingProgress: [ :ea| 'Searching for overrides in ', ea asString ].
...
here, rPackageSet methods and rPackageSet overrriddenMethods create RGMethodDefinition for all, trait and non trait methods.
We could try to solve this by adding a #reject:
rPackageSet methods reject:#isFromTrait .....
-> we need to write a script to delete all the wrong methods.
On 14 Oct 2015, at 17:16, Nicolai Hess <nicolaihess@web.de <mailto:nicolaihess@web.de>> wrote:
Please, someone can look at the Collections-Tests The ReleaseTest complains about
testLocalMethodsOfTheClassShouldNotBeRepeatedInItsTraits (These are all Test-subclasses that use traits, but all(!) trait method are compiled in the class instead, this happened after someone moved the Test packages (for bootstrap?)
OrderedCollectionTest FloatArrayTest ArrayTest DateTest HeapTest MorphicTextAdapter LinkedListTest DatePrintFormatTester StackTest CheckboxButtonMorph IntervalTest DateAndTimeTest SimpleButtonMorph MethodDictionaryTest SetTest DictionaryTest BagTest SymbolTest StringTest CollectionRootTest SortedCollectionTest