On 2012-09-09, at 13:18, GOUBIER Thierry <thierry.goubier@cea.fr> wrote:
________________________________________ De : pharo-project-bounces@lists.gforge.inria.fr [pharo-project-bounces@lists.gforge.inria.fr] de la part de Camillo Bruni [camillobruni@gmail.com] Date d'envoi : dimanche 9 septembre 2012 12:48 Ã : Pharo-project@lists.gforge.inria.fr Objet : Re: [Pharo-project] NewClassOrganizer
Ordering of protocols should happen in the Browser not in the model.
Hum, it looks like to save a few lines there, it's gonna cost a few thousands lines and caching complexity in the Browser.
I doubt that you'll need any caching there, for any given protocol finding the proper methods should be O(1), so the only thing that's left is ordering the protocol. - define a global ordered collection of predefined categories which will be sorted first - sort the rest alphabetically... so that's an O(n) lookup overhead for the all the entries. given that there is hardly any class defining 100 protocols you can redo that calculation as often as you want...
Protocols are simple dictionary entries, the old implementation simply did not want to use dicts for performance / space reasons.
I doubt that we will add explicit ordering to protocols...
Then the new implementation looks worse than the previous one, from a GUI point of view in addition to the performance / space ones.
not at all... the old categories are a big mess without any documentation => nobody will every maintain that and as mentioned above, the only trade-off is space, which honestly you cannot complain about unless we hit something like a 300MB boundary like Eclipse...