Thanks janko Stef On Dec 29, 2008, at 6:00 PM, Janko Mivšek wrote:
Hi Stef,
Stéphane Ducasse wrote:
I checked and - pharo does not complain for what seems good. So no bugs from our side.
- SwazooBenchmarks seems to have an instance class variable with uppercase Singleton
can you check and confirm. I tried to load beta2.2 Thanks
Yep, that's it! And it seems it comes from VW definition, where since 7.x you don't have class variables anymore but just shared ones. It seems I wrongly put this Singleton as the class instance variable and porting to Squeak ported that mistake too.
Sorry for that and the error will be corrected in the next release. In the meantime you can safely just ignore it.
Best regards Janko
On Dec 29, 2008, at 5:16 PM, Janko Mivšek wrote:
Hi Ramon,
Ramon Leon wrote:
Yes I contacted Janko if he can fix that I can fix of course but I'm a bit surprised that in Squeak the class variables are supposed to be lower case. I have in mind back from 1996 that they must be uppercase. Janko, I'm pretty sure Lukas was talking about a class instance variable, not a class variable. Class instance variables should be lowercase while class vars are uppercase. Swazoo apparently contains a class- instance variable that is uppercased, which regardless of the outcome of this discussion, should probably be fixed. Here is the exact definition of a Swazoo class in question:
Object subclass: #SwazooServer instanceVariableNames: 'sites servers watchdog' classVariableNames: 'Singleton' poolDictionaries: '' category: 'Swazoo-Core'
And here the same definition of Swazoo SiteRegistry in VW 3.0 back from 2000:
Object subclass: #SiteRegistry instanceVariableNames: 'sites servers ' classVariableNames: 'Singleton ' poolDictionaries: '' category: 'Swazoo'
So, this is obviously a class variable definition and not an instance one. Where is the problem then? I don't find any class instance variables in other classes and in any way the Singleton should be only class variable in use in Swazoo.
Best regards Janko
-- Janko Mivšek AIDA/Web Smalltalk Web Application Server http://www.aidaweb.si
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project