On 09 Feb 2016, at 13:38, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
p.s. To all who see this email: Bloc needs more complains
:)
Some random thoughts: BlWorldElement and BlSpaceElement sounds like this is for elements *in* space or *in* world, not like *the* WorldElement.
I agree I think that BlWorldEllement should be BlWorld and BlSpaceElement should be BlSpace
in general, using âelementâ seems to be just as using âobjectâ :P
Looking at BlElement definition:
Object subclass: #BlElement uses: TBlPropertiesOwner instanceVariableNames: 'ownerReference visible properties layoutProperties zIndex spaceReference eventListener errorOnDraw locked extent shape layoutStrategy children nextElementReference previousElementReference measuredExtent requestingLayout oldExtentMeasurementSpec transformation' classVariableNames: '' package: 'Bloc-Core-!Core-Basic'
The properties visible and locked, somehow they don't fit in the structure a BlElement provides, I don't know why but it looks strange. zIndex: what defines the order of elements, its zIndex or *are* they in different Bloc-Layers and a zIndex would be superfluous?
Are measuredExtent requestingLayout oldExtentMeasurementSpec attributes, a BlElement always has and needs, or are they only used during layouting?
children ownerReference nextElementReference previousElementReference, would it make sense to encapsulate this in one new class, something like a treeNode/structureNode?
Cheers, Alex
-------------------------------------------- Stéphane Ducasse http://stephane.ducasse.free.fr <http://stephane.ducasse.free.fr/> http://www.synectique.eu <http://www.synectique.eu/> / http://www.pharo.org <http://www.pharo.org/> 03 59 35 87 52 Assistant: Julie Jonas 03 59 57 78 50 03 59 35 86 16
S. Ducasse - Inria 40, avenue Halley, Parc Scientifique de la Haute Borne, Bât.A, Park Plaza Villeneuve d'Ascq 59650 France