Hi Bernardo, I would say no: don't revert anything before testing. 2015-08-20 19:56 GMT+02:00 Bernardo Ezequiel Contreras <vonbecmann@gmail.com
:
Hi all,
it seems i have changed a method (Rectangle>>#intersect:ifNone:) that could impact in the performance of the UI. see below
---------- Forwarded message ---------- From: Nicolas Cellier <notifications@github.com> Date: Thu, Aug 20, 2015 at 1:18 PM Subject: Re: [pharo-core] 50248 (3d7f1f3) To: pharo-project/pharo-core <pharo-core@noreply.github.com>
IMO, min: and max: were intentionally inlined for speed purpose, since primitive graphics objects are heavily used. That's questionnable, but maybe still necessary on slow machines like Pi.
â Reply to this email directly or view it on GitHub <https://github.com/pharo-project/pharo-core/commit/3d7f1f3ac45310096f565c2d1...> .
so, do i have to revert that change?
thanks, sorry for the inconvenience
-- Bernardo E.C.
Sent from a cheap desktop computer in South America.