On Jun 27, 2009, at 9:24 PM, Hernan Wilkinson wrote:
With this fix, all changes made to classes like adding instance variables, class variables, changing method categories, changing class package, etc. are saved to the changes file. I spend some time trying to find the best way to do it, like Stef said some time ago, the code is not easy to understand, so I decided to do it the simplest way. So each method that changes something in the class, it also logs the change. The good thing is that no matter where the change is made, it is saved.
Did you pay attention that certain operation are silent (do not add to the change)
right now is saving all the changes to the log. I saw something about doit silent but I do not understand why a change should not be save, why is that?
because sometimes you want to install code without polluting the changes set - halt - breakpoint and all kinds of trickery
The drawback is that when changing a class from the browser's code panel, it saves the definition twice. All the changes are saved as "doit", so no change to the file in was necessary.
What do you mean by doit? Normally only class def (which is a mistake) are saved like doit.
I agree that it is a mistake, but I think that the first steep is to save everything. The next one should be to change the format.
yes having something more declarative and object-oriented
I needed this fix becuase I lost a lot of work because pharo hanged on me many times...
argh. Let us know if you can reproduce that. I think that we changed a lot and pharo 1.0 may be less stable than Squeak3.9
Ironically, I had a power down issue when testing it, so I did not loose anything! (and help me to find a bug). All the changes are tested. See ClassOrganizerTest, ClassTest and StandardSourceFileArrayTest
Hernan can you open an issue in the Bugtracker
I did, it is the 825, it is in the subject :-)
OK :)
Stef
Bye, Hernan.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project