Sean P. DeNigris wrote:
This one smells funny to me...
Object>>#browse ^ self systemNavigation browseClass: self class
A less surprising API might be: - Object>>#browseClass - and, Class>>#browse as implemented above
What do you think?
----- Cheers, Sean
In GTInspector, right click on an object and you get the option: * Browse which takes you to view the code. In old inspector, right click on an object you get three options: * Browse Full * Browse Class * Browse Hierarchy which takes you to various different code viewers. Together I think this shows its fairly well established that 'Browse' on its own means "view the object's code". Its established that menu options effectively map to messages sent to the object. So then would you need to change the four menu items above to: * Browse Class * Browse Class Full * Browse Class Class * Browse Class Hierarchy. Then I think you'd need to follow through changing all senders of #fullOnClass: from #browse... to #browseClass... Also, is there any foreseeable situation where a "Browse" menu would provide a function that is not code viewing, that Explore and Inspect would not cover? So in this case, because of the paradigm of mapping from menu items to message sends, unless the menu options change to suit, I think the behaviour expected from #browse is reasonably well defined and the implementation is fine. cheers -ben