On 25 May 2017, at 09:48, Johan Brichau <johan@inceptive.be> wrote:
Hi Sven and Thorsten,
Thanks for this. Iâm taking the steps necessary to integrate everything now: - copy to github - adapt the configuration for 3.2.x
OK, thanks, Johan.
In the future, making pull requests against the github repo will be the easiest and advised way.
I want to try (in the future), but the way I have Seaside in my images, it is loaded from StHub, so I have no GitHub repos. Is there a place/document that describes the procedure of how to do it the recommended way ? And a description of how the releases are structured ?
Iâll ping back here later today..
johan
On 25 May 2017, at 00:38, Sven Van Caekenberghe <sven@stfx.eu> wrote:
Thx Torsten.
Is that enough to get it included in the main development line, what else has to happen ?
On 24 May 2017, at 22:34, Torsten Bergmann <astares@gmx.de> wrote:
Hi Sven,
I uploaded the MCZ to the Seaside repo htto://smalltalkhub.com/mc/Seaside/Seaside32/main and tested it. Looks fine and all is working for me.
The only thing I'm not sure about is that Philippe (PMM) in Seaside-Pharo-Tools-Spec-pmm.21 made a distinction to either use NewListModel or FastTableModel. The issue was also noted in https://github.com/SeasideSt/Seaside/issues/869
I guess this not necessary anymore as Pharo 6 has FastTableModel only.
Additionally: ============ I extended your version so that "Browse" opens a real webbrowser when two conditions are met: - the Pharo image includes the WebBrowser package (which one can load from catalog) - teh adaptor is running
In any other case it has the same behavior as before by just inspecting the adaptor.
This extension can be found in "Seaside-Pharo-Tools-Spec-TorstenBergmann.28" in the same repository.
Thanks Torsten
Gesendet: Mittwoch, 24. Mai 2017 um 16:27 Uhr Von: "Sven Van Caekenberghe" <sven@stfx.eu> An: "Pharo Development List" <pharo-dev@lists.pharo.org>, "Seaside - developer list" <seaside-dev@lists.squeakfoundation.org> Betreff: [Pharo-dev] Updated Seaside Control Panel for Pharo 6 / Seaside 3.2
Hi,
I updated the Seaside Control Panel for Pharo 6 / Seaside 3.2. As far as I can see, it works fine now.
I don't know the exact procedure to get this into Seaside proper, hence I include the MC package.
It is obviously important to get this in before we release Pharo 6, but it is probably also a good idea that somebody else has a look at what I did.
=== Name: Seaside-Pharo-Tools-Spec-SvenVanCaekenberghe.20 Author: SvenVanCaekenberghe Time: 24 May 2017, 4:17:49.490067 pm UUID: b1168881-a70c-0d00-9de6-8d500cd45859 Ancestors: Seaside-Pharo-Tools-Spec-JohanBrichau.19
Updated the Seaside Control Panel for Pharo 6 / Seaside 3.2 using latest Spec conventions
- Add a refresh button to the main toolbar to sync with changes done outside the UI (add a #refreshAdaptors action and use it for add/remove updating as well) - Inform the user when remove fails due to a still running adaptor - Use IconListModel instead of NewListModel - Fix selection maintenance on the list of adaptors - Fix the context menu on the list of adaptors - Use new recommended icon access method - Added help strings to the buttons in the main toolbar - Added a proper About text - Add a window icon - Remove unused state/action stuff from the toolbar implementation ===
Sven
PS: The 'Spec UI Framework' book was helpful as was Nicolai's help on the ML - Thank you.
_______________________________________________ seaside-dev mailing list seaside-dev@lists.squeakfoundation.org http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
_______________________________________________ seaside-dev mailing list seaside-dev@lists.squeakfoundation.org http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
_______________________________________________ seaside-dev mailing list seaside-dev@lists.squeakfoundation.org http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev