- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Issue 3911 in pharo: Change updater to allow updating a release image

by pharo＠googlecode.com

Updates: Status: Closed Comment #5 on issue 3911 by marcus.d...(a)gmail.com: Change updater to allow updating a release image http://code.google.com/p/pharo/issues/detail?id=3911 in 12346

April 3, 2011

Re: [Pharo-project] syntax highlighting for (stateful) traits (non-local methods)

by Alexandre Bergel

> Yes I see, I did forget to implement all the tools to make it work. You know... I started the stateful traits implementation on Friday... I'm glad that I'm as far as I am ;) However, in the new image I can close it. Exceptions are just very slow for some reason. This is cool that you're working on this topic. > There are not many comments around, and not enough tests. After I finish my paperwriting I'll go over it and document everything! It's a sneak preview ... did I mention that? ;) Yes, papers are important. Papers are often more used than implementations. Cheers, Alexandre > > For the slots, yes there are subclasses of the standard Slot class; and they can provide non-standard access. > > You might notice that changing a class' layout is a lot faster thanks to bytecode level method updates :) Or not, hence I mention it again. That's all part of this particular image. > > cheers, > Toon > > On 04/03/2011 02:19 PM, Alexandre Bergel wrote: >> I tried the image. I hadn't seen such a look for years :-) >> >> StatefulTrait named: #TStatefulTest >> layout: PointerLayout >> slots: { >> #tfirst => Slot. >> #tsecond => Slot. >> } >> uses: {} >> category: #'Slot-Traits-Test' >> >> I checked what layout: is about. StatefulTrait is a dry in terms of comments :-) >> Why do you have "=> Slot" ? What can tfirst be else, if not a slot? Can you specialize the slots to use a particular layout? >> >> I played a bit with your image. I cannot access tfirst in MyFirstTest. Your implementation is conform to the policy you defined above. >> >> Your image is a bit unstable. I tried to press the tab key for autocompletion, and got some debuggers that I couldn't close. I misspelled aMethod with aMethdo, and got plenty of debuggers related to QQParser >> >> Cheers, >> Alexandre >> >> On 3 Apr 2011, at 05:34, Toon Verwaest wrote: >> >>> Oh yes.. I am :) >>> >>> http://pinocchio.unibe.ch/~tverwaes/slots.tar.gz gives you an image with an example of a stateful trait open. The state is always private to the class / trait at the moment and it already seems to work pretty well. I modified the NewInspector slightly to show you the proper data (although this needs to be cleaned up, and state should be sorted per trait), and the OB to compile and syntax highlight in the right context. >>> >>> I didn't test more complex examples yet than what's open, but it's designed generically enough that I'm confident it does ... euhm ... ;) >>> >>> cheers, >>> Toon >>> >>> On 04/03/2011 10:44 AM, StÃ©phane Ducasse wrote: >>>> On Apr 2, 2011, at 9:10 PM, Toon Verwaest wrote: >>>> >>>>> Hi all, >>>>> >>>>> as you know I'm working on stateful traits using my new classbuilder >>>> no >>>> Are you? >>>> >>>> >>>>> etc... Now I noticed that methods are highlighted always inside of the context of the class that's active in the class browser. How can I change this? There is already a useful method around to figure out which object it belongs to: >>>>> >>>>> SomeClass traitOrClassOfSelector: #aMethod >>>>> >>>>> This actually will tell me which trait it comes from. So now I could apply syntax coloring in the context of the trait rather than the class. Since in my implementation state is all private to the trait / class, they should be able to access their own state but not see the state of the other class. This obviously also means that coloring should happen in the correct scope, rather than always in the scope of the class. >>>>> >>>>> At the moment the coloring doesn't really make sense ... but then it didn't really matter that much until now. Although if you try to access state in a method coming from a trait, while coding in your IDE you'll probably have the impression you can access your local instvars. I don't really know what the semantics are there... but it seems a bit broken :) >>>>> >>>>> cheers, >>>>> Toon >>>>> >>> > > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

April 3, 2011

Re: [Pharo-project] syntax highlighting for (stateful) traits (non-local methods)

by Alexandre Bergel

>> Can you merge state? What happens with C.x uses T.x ? Methods of T will use T.x and methods of C will use C.x? >> > At the moment you can't, but in our slot library we have alias slots. So that we could use to do the same tricks as with methods: required slots, provided slots, "defrosted slots", ... I am lost. I understand that a trait have a class have a different scope of slots. But you cannot define C.x and T.x? Why? Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

April 3, 2011

Re: [Pharo-project] syntax highlighting for (stateful) traits (non-local methods)

by Alexandre Bergel

I guess that what Stef meant is the following: One of the problems when sharing code among mixin and stateful-trait application is that the physical layout of instances varies between mixin applications. (Section 6.5 of http://bergel.eu/download/papers/Berg07e-StatefulTraits.pdf) We have T.y and C.x T has a method #getY, for which its bytecode returns the first slot (i.e., y). If C uses T, the #getY needs to be adapted to return the second slot right? Cheers, Alexandre On 3 Apr 2011, at 06:23, Toon Verwaest wrote: > >> How are you dealing with the fact that the application of trait with state may change the layout of the class user and that you should recompile >> all the class method to deal with that. And if you have two traits having state you should do the same but for the traits themselves. >> So this means that the method in the traits cannot be reused (ok now we do not reuse them anymore sniff it was a nice model - reuse without cost of duplication). >> >> How your layout object helps you for that? >> This is why I want first class slot :) >> >> Stef > I don't think I fully understand what you are saying... > > The model is like this at the moment: > > Every class has a layout attached to it. Layouts that have slots have LayoutScopes. For example, if you have > > Class A super: Object slots: #(a b c) > Class B super: A slots: #(d e) > > Then you get > > Class A <-> PointerLayout -> LayoutClassScope #(a b c) -> LayoutClassScope #() -> LayoutEmptyScope > Class B <-> PointerLayout -> LayoutClassScope #(d e) -> LayoutClassScope #(a b c) -> LayoutClassScope #() -> LayoutEmptyScope > > where LayoutClassScope #(a b c) is shared between the scope of B and the layout of A. The empty LayoutClassScope comes from Object and is shared as well. > > Now if you get a stateful trait, a stateful trait C with slots #(f) looks like this: > > StatefulTrait C <-> PointerLayout -> LayoutTraitScope #(f) -> LayoutEmptyScope > > If you were to install the trait C on B, it would become: > > Class B <-> PointerLayout -> LayoutClassScope #(d e) -> LayoutForkScope -> LayoutClassScope #(a b c) -> LayoutClassScope #() -> LayoutEmptyScope > > where the LayoutForkScope would have sidescopes: > LayoutForkScope sideScopes: { LayoutTraitScope #(f) -> LayoutEmptyScope } > > Then the classbuilder will build classes by always following the public path. Sidescopes aren't public. When you compile methods on the trait, its scopes are public; but when they are installed, they aren't public since they are sidescopes. > > However, every method is compiled on the trait or class that provided the selector, so when you install the trait-related method, it will see the state related to the trait. And when the trait is installed, the sidescopes are actually copies of the original traitscope, so the actual fieldindices are updated in the LayoutTraitScope when it's installed. > > Then how methods get updated based on state changes is at the moment completely unrelated to the trait implementation, since methods are already updated in my class builder based on a MethodModificationModel that knows how the fields have changed. This will use the decompiler/bytecode modification/recompiler to update the methods in place. > > The only thing that I forgot to do until now is to actually modify all the classes that use a trait, every time the state of a trait changes... But that's straightforward. We just have to ask for the users of the stateful trait and reapply their class modification. That's all nicely modeled already. > > As for overlapping state from multiple stateful traits.... there is no overlapping state since all state is private to the trait! You can use 2 traits with same slot names. This is no problem at all since the state is only seen by that trait. And their methods are only compiled on that trait, so the methods will always know exactly which of the slots you are referring to. > > I hope this helps somehow :) Otherwise ... wait for the paper ;) > > cheers, > Toon > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

April 3, 2011

Re: [Pharo-project] syntax highlighting for (stateful) traits (non-local methods)

by Alexandre Bergel

I tried the image. I hadn't seen such a look for years :-) StatefulTrait named: #TStatefulTest layout: PointerLayout slots: { #tfirst => Slot. #tsecond => Slot. } uses: {} category: #'Slot-Traits-Test' I checked what layout: is about. StatefulTrait is a dry in terms of comments :-) Why do you have "=> Slot" ? What can tfirst be else, if not a slot? Can you specialize the slots to use a particular layout? I played a bit with your image. I cannot access tfirst in MyFirstTest. Your implementation is conform to the policy you defined above. Your image is a bit unstable. I tried to press the tab key for autocompletion, and got some debuggers that I couldn't close. I misspelled aMethod with aMethdo, and got plenty of debuggers related to QQParser Cheers, Alexandre On 3 Apr 2011, at 05:34, Toon Verwaest wrote: > Oh yes.. I am :) > > http://pinocchio.unibe.ch/~tverwaes/slots.tar.gz gives you an image with an example of a stateful trait open. The state is always private to the class / trait at the moment and it already seems to work pretty well. I modified the NewInspector slightly to show you the proper data (although this needs to be cleaned up, and state should be sorted per trait), and the OB to compile and syntax highlight in the right context. > > I didn't test more complex examples yet than what's open, but it's designed generically enough that I'm confident it does ... euhm ... ;) > > cheers, > Toon > > On 04/03/2011 10:44 AM, StÃ©phane Ducasse wrote: >> On Apr 2, 2011, at 9:10 PM, Toon Verwaest wrote: >> >>> Hi all, >>> >>> as you know I'm working on stateful traits using my new classbuilder >> no >> Are you? >> >> >>> etc... Now I noticed that methods are highlighted always inside of the context of the class that's active in the class browser. How can I change this? There is already a useful method around to figure out which object it belongs to: >>> >>> SomeClass traitOrClassOfSelector: #aMethod >>> >>> This actually will tell me which trait it comes from. So now I could apply syntax coloring in the context of the trait rather than the class. Since in my implementation state is all private to the trait / class, they should be able to access their own state but not see the state of the other class. This obviously also means that coloring should happen in the correct scope, rather than always in the scope of the class. >>> >>> At the moment the coloring doesn't really make sense ... but then it didn't really matter that much until now. Although if you try to access state in a method coming from a trait, while coding in your IDE you'll probably have the impression you can access your local instvars. I don't really know what the semantics are there... but it seems a bit broken :) >>> >>> cheers, >>> Toon >>> >> > > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

April 3, 2011

Re: [Pharo-project] syntax highlighting for (stateful) traits (non-local methods)

by Alexandre Bergel

> So now I could apply syntax coloring in the context of the trait rather than the class. Do you mean coloring message sends in a trait's method? For self call that is not specified in the requirement? > Since in my implementation state is all private to the trait / class, they should be able to access their own state but not see the state of the other class. This obviously also means that coloring should happen in the correct scope, rather than always in the scope of the class. Can you merge state? What happens with C.x uses T.x ? Methods of T will use T.x and methods of C will use C.x? Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

April 3, 2011

Re: [Pharo-project] syntax highlighting for (stateful) traits (non-local methods)

by Toon Verwaest

On 04/03/2011 02:29 PM, Alexandre Bergel wrote: > I guess that what Stef meant is the following: > One of the problems when sharing code among mixin and stateful-trait application is that the physical layout of instances varies between mixin applications. (Section 6.5 of http://bergel.eu/download/papers/Berg07e-StatefulTraits.pdf) So as your paper states ... methods may have to be copied down if the layout is different. In the case of traits you always flatten out methods; and the default traits implementation for Pharo ALWAYS recompiles the methods when copying them. I just make sure they get recompiled in the installed trait's scope. Of course in our case there is no such thing as "copying down", since traits are flattened, and not part of the hierarchy, such as is the case for mixins. So no difficult transformations are required, recompiling is good enough. It would be faster to just update the bytecode indices by decompiling and recompiling; but as said before ... that's just work I can't really afford at this very moment. cheers, Toon

April 3, 2011

Re: [Pharo-project] syntax highlighting for (stateful) traits (non-local methods)

by Toon Verwaest

On 04/03/2011 02:37 PM, Alexandre Bergel wrote: >> Indeed. And this is not different from changing a layout of a class having as impact that you have to update the methods. >> The default traits implementation already recompiles all methods anyway whenever it installs the trait. What I do is, I just let the trait compile itself on the subpart of the class that originally defined the trait. > allMethods from where? The methods coming from the trait are recompiled on the class when they are installed. Actually this should just do bytecode rewriting... but I don't have time to completely rewrite the traits just yet. I'll do that in May I guess ;) > Put a ref to copydown, from strongtalk. Will do ;) Now I fixed the bug in MC, the PlayOut project. Now it works; you can define an instance variable from a trait also on the class and they will not overlap. cheers, Toon

April 3, 2011

Re: [Pharo-project] syntax highlighting for (stateful) traits (non-local methods)

by Marcus Denker

On Apr 3, 2011, at 1:29 PM, Alexandre Bergel wrote: > I guess that what Stef meant is the following: > One of the problems when sharing code among mixin and stateful-trait application is that the physical layout of instances varies between mixin applications. (Section 6.5 of Yes, and the physical layout is now modeled as objects. (See Hierarchy of AbstractLayout). > > We have T.y and C.x > T has a method #getY, for which its bytecode returns the first slot (i.e., y). If C uses T, the #getY needs to be adapted to return the second slot right? > Yes. Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

April 3, 2011

Re: [Pharo-project] syntax highlighting for (stateful) traits (non-local methods)

by Toon Verwaest

On 04/03/2011 02:31 PM, Alexandre Bergel wrote: >>> Can you merge state? What happens with C.x uses T.x ? Methods of T will use T.x and methods of C will use C.x? >>> >> At the moment you can't, but in our slot library we have alias slots. So that we could use to do the same tricks as with methods: required slots, provided slots, "defrosted slots", ... > I am lost. I understand that a trait have a class have a different scope of slots. But you cannot define C.x and T.x? Why? > > Cheers, > Alexandre Doh, I see. There's a stupid test that raises a conflict cause it finds slots that are conflicting. While actually they are not conflicting. Let me fix that ;) cheers, Toon

April 3, 2011