- Pharo-dev - lists.pharo.org

Re: [Pharo-project] [Hudson] Jenkins

by Marcus Denker

On May 22, 2011, at 8:55 AM, Geert Claes wrote: > > Marcus Denker-4 wrote: >> >> The problem is that this is a company wide installation serving many >> projects... >> Pharo is just one of them. >> > > But everything is Pharo based and even the URL includes "Pharo" does it not? > Yes, the IT services provide infrastructure that creates Jenkins setups. E.g. we can request one for RMOD, and there will be one for Rmod. Yes, we could request them to extend this meta-setup it with changing the look. But the thing is that this *We* can not do, but the admines would need to do it. And it would be work to provide a UI for uploading images, checking they are good... And my feeling is that they have other things that are more important to do (the whole setup is in test mode...) Especially we should *use* it before running back and requesting even more changes. (and unimportant ones, especially)... It's just not a good idea to do that now. Marcus > -- > View this message in context: http://forum.world.st/Hudson-Jenkins-tp3538245p3541662.html > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. > -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

May 22, 2011

Re: [Pharo-project] [Hudson] Jenkins

by Geert Claes

Marcus Denker-4 wrote: > > The problem is that this is a company wide installation serving many > projects... > Pharo is just one of them. > But everything is Pharo based and even the URL includes "Pharo" does it not? -- View this message in context: http://forum.world.st/Hudson-Jenkins-tp3538245p3541662.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

May 22, 2011

Re: [Pharo-project] [Hudson] Jenkins

by Marcus Denker

On May 21, 2011, at 7:54 PM, Geert Claes wrote: > Hi Marcus, Maybe you could replace the resource images with the attached > images - replaced "Jenkins" with "Pharo" :) > The problem is that this is a company wide installation serving many projects... Pharo is just one of them. > Re-branding: > > http://forum.world.st/file/n3540934/title.png title.png > http://forum.world.st/file/n3540934/jenkins.png jenkins.png > http://forum.world.st/file/n3540934/topbar.png topbar.png > > -- > View this message in context: http://forum.world.st/Hudson-Jenkins-tp3538245p3540934.html > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. > -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

May 22, 2011

Re: [Pharo-project] ChangeSet changedMessageList broken

by Benjamin

On May 22, 2011, at 2:29 AM, Stefan Marr wrote: > Hi: > > On 22 May 2011, at 01:56, Benjamin wrote: > >> The "problem" is that MethodReference were used either it was for a method or for a comment. And in this case, the selector was set to #Comment . >> Now, there is SourcedMethodReference for methods, and CommentReference for comments. >> >> So this example should be changed I guess. > > > So, the proper implementation would be the following? (now uses CommentReference) > > changedMessageList > "Used by a message set browser to access the list view information." > > | messageList | > messageList := OrderedCollection new. > changeRecords associationsDo: [:clAssoc | | classNameInParts classNameInFull | > classNameInFull := clAssoc key asString. > classNameInParts := classNameInFull findTokens: ' '. > > (clAssoc value allChangeTypes includes: #comment) ifTrue: > [messageList add: > (CommentReference class: (Smalltalk globals classNamed: classNameInParts first))]. > > clAssoc value methodChangeTypes associationsDo: [:mAssoc | > (#(remove addedThenRemoved) includes: mAssoc value) ifFalse: > [messageList add: > (SourcedMethodReference new > setClassSymbol: classNameInParts first asSymbol > classIsMeta: classNameInParts size > 1 > methodSymbol: mAssoc key > stringVersion: classNameInFull, ' ' , mAssoc key)]]]. > ^ messageList asArray sort > > > > Well well, thats not really nice. CommentReference is not entirely polymorphic to MethodReference. > > It should have > CommentReference>>#category > ^ self actualClass category > So let's add it ^^ Ben > to be able to move #topLevelPackageName from MethodReference to SourceReference. Every piece of source is part of some package, no? Including the class comments. Well, at least it breaks our file-out mechanism if that is not true. > > Best regards > Stefan > >> >> >> >> Ben >> >> >> On May 21, 2011, at 11:41 PM, Stefan Marr wrote: >> >>> Hello: >>> >>> The following example is broken: >>> >>> ChangeSet new commentClass: ChangeSet; changedMessageList >>> >>> It will raise an exception that no #Comment message was found in the ChangeSet class. >>> (BTW: the key not found error does not name the key, which is rather inconvenient) >>> >>> The reason seems to be a change in ChangeSet>>#changedMessageList. >>> >>> The change is tracked as being done by Benjamin Van Ryseghem (11/6/2010 22:11) >>> and seems to switch from MethodReference to SourcedMethodReference, which breaks the example. >>> >>> Does anyone know the intention or context of this change? >>> Is it possible to revert to Marcus' pervious version of that method? >>> >>> A test for this bug could be the lines of: >>> >>> >>> >>> testChangedMessageListAndComments >>> | changeSet | >>> changeSet := ChangeSet new. >>> changeSet commentClass: ChangeSet. >>> self assert: 1 equals: changeSet changedMessageList size. >>> self assert: ((changeSet at: 1) isKindOf: MethodReference). >>> self assert: #Comment equals: (changeSet at: 1) methodSymbol. >>> >>> Best regards >>> Stefan >>> >>> -- >>> Stefan Marr >>> Software Languages Lab >>> Vrije Universiteit Brussel >>> Pleinlaan 2 / B-1050 Brussels / Belgium >>> http://soft.vub.ac.be/~smarr >>> Phone: +32 2 629 2974 >>> Fax: +32 2 629 3525 >>> >>> >> >> > > -- > Stefan Marr > Software Languages Lab > Vrije Universiteit Brussel > Pleinlaan 2 / B-1050 Brussels / Belgium > http://soft.vub.ac.be/~smarr > Phone: +32 2 629 2974 > Fax: +32 2 629 3525 > >

May 22, 2011

Re: [Pharo-project] ChangeSet changedMessageList broken

by Stefan Marr

Hi: On 22 May 2011, at 01:56, Benjamin wrote: > The "problem" is that MethodReference were used either it was for a method or for a comment. And in this case, the selector was set to #Comment . > Now, there is SourcedMethodReference for methods, and CommentReference for comments. > > So this example should be changed I guess. So, the proper implementation would be the following? (now uses CommentReference) changedMessageList "Used by a message set browser to access the list view information." | messageList | messageList := OrderedCollection new. changeRecords associationsDo: [:clAssoc | | classNameInParts classNameInFull | classNameInFull := clAssoc key asString. classNameInParts := classNameInFull findTokens: ' '. (clAssoc value allChangeTypes includes: #comment) ifTrue: [messageList add: (CommentReference class: (Smalltalk globals classNamed: classNameInParts first))]. clAssoc value methodChangeTypes associationsDo: [:mAssoc | (#(remove addedThenRemoved) includes: mAssoc value) ifFalse: [messageList add: (SourcedMethodReference new setClassSymbol: classNameInParts first asSymbol classIsMeta: classNameInParts size > 1 methodSymbol: mAssoc key stringVersion: classNameInFull, ' ' , mAssoc key)]]]. ^ messageList asArray sort Well well, thats not really nice. CommentReference is not entirely polymorphic to MethodReference. It should have CommentReference>>#category ^ self actualClass category to be able to move #topLevelPackageName from MethodReference to SourceReference. Every piece of source is part of some package, no? Including the class comments. Well, at least it breaks our file-out mechanism if that is not true. Best regards Stefan > > > > Ben > > > On May 21, 2011, at 11:41 PM, Stefan Marr wrote: > >> Hello: >> >> The following example is broken: >> >> ChangeSet new commentClass: ChangeSet; changedMessageList >> >> It will raise an exception that no #Comment message was found in the ChangeSet class. >> (BTW: the key not found error does not name the key, which is rather inconvenient) >> >> The reason seems to be a change in ChangeSet>>#changedMessageList. >> >> The change is tracked as being done by Benjamin Van Ryseghem (11/6/2010 22:11) >> and seems to switch from MethodReference to SourcedMethodReference, which breaks the example. >> >> Does anyone know the intention or context of this change? >> Is it possible to revert to Marcus' pervious version of that method? >> >> A test for this bug could be the lines of: >> >> >> >> testChangedMessageListAndComments >> | changeSet | >> changeSet := ChangeSet new. >> changeSet commentClass: ChangeSet. >> self assert: 1 equals: changeSet changedMessageList size. >> self assert: ((changeSet at: 1) isKindOf: MethodReference). >> self assert: #Comment equals: (changeSet at: 1) methodSymbol. >> >> Best regards >> Stefan >> >> -- >> Stefan Marr >> Software Languages Lab >> Vrije Universiteit Brussel >> Pleinlaan 2 / B-1050 Brussels / Belgium >> http://soft.vub.ac.be/~smarr >> Phone: +32 2 629 2974 >> Fax: +32 2 629 3525 >> >> > > -- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 2974 Fax: +32 2 629 3525

May 22, 2011

Re: [Pharo-project] ChangeSet changedMessageList broken

by Benjamin

The "problem" is that MethodReference were used either it was for a method or for a comment. And in this case, the selector was set to #Comment . Now, there is SourcedMethodReference for methods, and CommentReference for comments. So this example should be changed I guess Ben On May 21, 2011, at 11:41 PM, Stefan Marr wrote: > Hello: > > The following example is broken: > > ChangeSet new commentClass: ChangeSet; changedMessageList > > It will raise an exception that no #Comment message was found in the ChangeSet class. > (BTW: the key not found error does not name the key, which is rather inconvenient) > > The reason seems to be a change in ChangeSet>>#changedMessageList. > > The change is tracked as being done by Benjamin Van Ryseghem (11/6/2010 22:11) > and seems to switch from MethodReference to SourcedMethodReference, which breaks the example. > > Does anyone know the intention or context of this change? > Is it possible to revert to Marcus' pervious version of that method? > > A test for this bug could be the lines of: > > > > testChangedMessageListAndComments > | changeSet | > changeSet := ChangeSet new. > changeSet commentClass: ChangeSet. > self assert: 1 equals: changeSet changedMessageList size. > self assert: ((changeSet at: 1) isKindOf: MethodReference). > self assert: #Comment equals: (changeSet at: 1) methodSymbol. > > Best regards > Stefan > > -- > Stefan Marr > Software Languages Lab > Vrije Universiteit Brussel > Pleinlaan 2 / B-1050 Brussels / Belgium > http://soft.vub.ac.be/~smarr > Phone: +32 2 629 2974 > Fax: +32 2 629 3525 > >

May 22, 2011

Re: [Pharo-project] bug in Nautilus/RPackage?

by Alexandre Bergel

Hi! I took a fresh 1.3 image, and do it the following: -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Gofer new squeaksource: 'Spy'; package: 'ConfigurationOfSpy'; load. (Smalltalk at: #ConfigurationOfSpy) project lastVersion load. Gofer new squeaksource: 'Nautilus'; package: 'ConfigurationOfNautilus'; load. (Smalltalk at: #ConfigurationOfNautilus) project lastVersion load -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= I see the packages Spy, Spy-Core, .... Clicking on Spy-Core raises an error: Does not understand NautilusUI>>historyChanged. Below the pharo debug file When I load Nautilus first then Spy, only an empty Spy package appears in the browser with: -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Gofer new squeaksource: 'Nautilus'; package: 'ConfigurationOfNautilus'; load. (Smalltalk at: #ConfigurationOfNautilus) project lastVersion load. Gofer new squeaksource: 'Spy'; package: 'ConfigurationOfSpy'; load. (Smalltalk at: #ConfigurationOfSpy) project lastVersion load. -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= I am ready to push Nautilus. Cheers, Alexandre On 20 May 2011, at 17:50, Benjamin wrote: > Can you inspect the RPackageOrganizer to see if it comes from RPackage or from Nautilus please ? > > > Thanks in advance, > > > Ben > > On May 20, 2011, at 10:26 PM, Alexandre Bergel wrote: > >>> I don't know how to reproduce the situation in the screenshot, but I have a small idea of what the problem is: >>> Your package Spy is composed of several subcategories. All the classes are defined in the subcategories but none is defined in the one called 'Spy'. >> >> All Spy classes are defined in a category Spy-XXX >> >>> In Rpackage, the classes are put inside the RPackage matching the category in which the class is defined >> >> What does it mean? How comes that the package Spy was created? Where does it come from? >> >> I just took a fresh 1.3 one click, downloaded Nautilus then Spy. Spy appear as one single package called 'Spy'. No idea where it comes from. >> >> Alexandre >> >>> >>> 2011/5/19 Alexandre Bergel <alexandre.bergel(a)me.com> >>> Thanks for making it happen :-) >>> >>> Alexandre >>> >>> >>> On 19 May 2011, at 15:39, StÃ©phane Ducasse wrote: >>> >>>> thanks for reporting it. >>>> >>>> do you have a reproducable way of arriving to this state? >>>> >>>>> Hi ! >>>>> >>>>> I think I bumped into a bug when using Nautilus. I am not sure whether this is due to RPackage or not. >>>>> >>>>> I loaded Spy, and apparently there is no class in the package within Nautilus. >>>>> >>>>> Cheers, >>>>> Alexandre >>>>> -- >>>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >>>>> Alexandre Bergel http://www.bergel.eu >>>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >>>>> >>>>> >>>>> >>>>> >>>>> <Screen shot 2011-05-19 at 11.21.23.png> >>>> >>>> >>> >>> -- >>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >>> Alexandre Bergel http://www.bergel.eu >>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >>> >>> >>> >>> >>> >>> >>> >> >> -- >> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >> Alexandre Bergel http://www.bergel.eu >> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >> >> >> >> >> >> > > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

May 22, 2011

[Pharo-project] ChangeSet changedMessageList broken

by Stefan Marr

Hello: The following example is broken: ChangeSet new commentClass: ChangeSet; changedMessageList It will raise an exception that no #Comment message was found in the ChangeSet class. (BTW: the key not found error does not name the key, which is rather inconvenient) The reason seems to be a change in ChangeSet>>#changedMessageList. The change is tracked as being done by Benjamin Van Ryseghem (11/6/2010 22:11) and seems to switch from MethodReference to SourcedMethodReference, which breaks the example. Does anyone know the intention or context of this change? Is it possible to revert to Marcus' pervious version of that method? A test for this bug could be the lines of: testChangedMessageListAndComments | changeSet | changeSet := ChangeSet new. changeSet commentClass: ChangeSet. self assert: 1 equals: changeSet changedMessageList size. self assert: ((changeSet at: 1) isKindOf: MethodReference). self assert: #Comment equals: (changeSet at: 1) methodSymbol. Best regards Stefan -- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 2974 Fax: +32 2 629 3525

May 21, 2011

Re: [Pharo-project] Set with nil

by Andres Valloud

Why this defensive approach to code that adds duplicate entries to a menu? Why not avoid the duplicated entries from being added to begin with? On 5/20/11 2:58 , Bernat Romagosa wrote: > You may want the collection from which you build a menu to be a Set > because you don't want to have repeated entries in a menu, and you'd > want nil to be there if your field can be empty. When the menu items are > automatically generated, it'd be nice to be able to do Whatever > buildMenuFrom: (myCollection asSet add: nil; yourself). > > IMO this would be more elegant than doing myCollection asSet > asOrderedCollection add: nil; yourself, or any other way to ensure the > elements are unique and the collection includes nil. > > 2011/5/20 Henrik Sperre Johansen <henrik.s.johansen(a)veloxit.no > <mailto:henrik.s.johansen@veloxit.no>> > > On 20.05.2011 11:36, Bernat Romagosa wrote: > > On a dropdown menu where you can choose between 'apple' -> > #apple, 'orange' -> #orange or 'nothing' -> nil, for example :) > > > Huh? > How does a Set figure into that? > > Cheers, > Henry > >

May 21, 2011

Re: [Pharo-project] VW's ObjectRegistry similar in Pharo?

by Mariano Martinez Peck

On Sat, May 21, 2011 at 2:42 AM, Andres Valloud < avalloud(a)smalltalk.comcastbiz.net> wrote: > I think you want the add: that returns true/false depending on whether the > object was there or not. In that way, you can just say add: and forget > about includes:. > > yes, exactly. That's what we ended up doing. Thanks > > On 5/19/11 15:34 , Mariano Martinez Peck wrote: > >> Hi guys. We are doing graph traversal (for Fuel) and we would love a >> collection to be really fast and only support two simple operations: >> #add: and #includes: >> The idea is that each object we process of the graph we put it in the >> collection and then for each object we have to ask whether it is >> included or not (to avoid cycles and putting the same object more than >> once). >> >> VW seems to have ObjectRegistry (subclass of IdentitySet) which is more >> or less that. It is used by ObjectTracer, which in fact is what we want >> to do. And even more, Parcels uses that ;) (or an extension of that). >> >> So...I wonder, is there a special collection implementation ideal for >> this case? is something similar to ObjectRegistry available for pharo ? >> >> Thanks in advance, >> >> -- >> Mariano >> http://marianopeck.wordpress.com >> >> > -- Mariano http://marianopeck.wordpress.com

May 21, 2011