- Pharo-dev - lists.pharo.org

Re: [Pharo-project] A radical proposal (to cut down dead code)

by Igor Stasenko

On 31 May 2011 21:44, laurent laffont <laurent.laffont(a)gmail.com> wrote: > Another idea (don't know how hard it is) is to have test coverage + comment > coverage in Hudson. > Then we can start to consider that dead code = code with no test or no > comment. Laurent, have you tried to run lint rule checker in pharo image? I tried once and if i remember correctly, there are like 30000 notices. Now, what you think, is it possible for any human to visit all of them step by step analyze and then fix the code? It is enormous amount of data (and most of it is just white noise, or insignificant detail). Now how to filter that noise and address the only things which you should take care of? And since we're continuting development, every time you doing an update, this stuff should be revisited, compared and cross-checked again. And we don't have such facility: take image A and B, and compare their lint output. I imagine this would require a quite sophisticated database , with UI on top of that, which will allow you to navigate through these notices mark them as invalid, or fixed etc etc.. What i mean that automated tools is cool. But they cannot solve all our problems: every such issue should be analyzed and considered by developer. Because we're still not yet at the point, where system can reason about itself and automatically improve itself without need of our attention :) If this day will come, then it will be the end of humanity (at least in its current form - homo sapiens sapiens ;) > Laurent. > -- Best regards, Igor Stasenko AKA sig.

May 31, 2011

Re: [Pharo-project] [Pharo-users] [COTDC] 69 - HostSystemMenusWindows

by Guillermo Polito

Me and the HostSystemMenusMacOSX are specializations of HostSystemMenusProxy. We know how to answer to #isActiveHostMenuProxyClass, which is used by HostSystemMenus class>>activeMenuProxyClass to determine the active menu. That's why I don't have direct references. Read HostSystemMenusProxy for more info. On Tue, May 31, 2011 at 3:51 PM, laurent laffont <laurent.laffont(a)gmail.com>wrote: > Today: HostSystemMenusWindows > > > Comment Of The Day Contest - One Day One Comment > Rules: > #1: Each day a not commented class is elected. Each day the best comment > will be integrated with name of the author(s). > #2: If you cannot comment it, deprecate it. > Results: http://code.google.com/p/pharo/wiki/CommentOfTheDayContest > > Laurent >

May 31, 2011

[Pharo-project] [COTDC] 69 - HostSystemMenusWindows

by laurent laffont

Today: HostSystemMenusWindows Comment Of The Day Contest - One Day One Comment Rules: #1: Each day a not commented class is elected. Each day the best comment will be integrated with name of the author(s). #2: If you cannot comment it, deprecate it. Results: http://code.google.com/p/pharo/wiki/CommentOfTheDayContest Laurent

May 31, 2011

Re: [Pharo-project] TilingWM improvements

by laurent laffont

> > > I write a test, to do the following (but you can load this method and you > can do now at hand to understand what I mean): maximize a window, use > topWindowMoveTop, then topWindowMoveBottonLeft. The result is that the > window is 1 / 8 the size of the screen (I attach screenshot). With the > resolution size of the current monitors or the possibility of having > multiple monitors and extend the main window Pharo through these, using > windows of 1 / 4 of the screen can be a waste, plus there are tools that do > not need more a small space. > Moreover, this way you can only have 4 move operations: topWindowMoveTop / > Bottom / Left / Rigth, since the rest of you combined the above. > Ah OK. Estelle at our local coding-dojo today told me that in xmonad there's this sort of behavior. Maybe another way is to add #moveUpward / #moveDownward / #moveLeftward / #moveRightward mapped to keyboard shortcuts. Laurent. > > > >> I've implemented automatic refresh (see TilingWMSettings >> class>>initialize). May break the first time you load it if you have a >> version before the change. >> > > Yes, I see, thanks. > > >> >> There's a first shot of GUI controls for world snapshot / navigation but >> it needs more work to be intuitive. >> >> > There are many new features, it is time to make a new screencast:) > > > > >> Laurent. >> >> 2011/5/28 GastÃ³n Dall' Oglio <gaston.dalloglio(a)gmail.com> >> >>> Laurent, coincidere change this method (o part of): >>> >>> TilingWM>>newTopWindowBoundsInArea: aBlock >>> SystemWindow topWindow bounds: (aBlock value: world clearArea). >>> >>> to this one: >>> >>> TilingWM>>newTopWindowBoundsInArea: aBlock >>> | topWindow | >>> (topWindow := SystemWindow topWindow) isMaximized >>> ifTrue: [ topWindow expandBoxHit. topWindow bounds: (aBlock value: world >>> clearArea) ] >>> ifFalse: [ topWindow bounds: (aBlock value: topWindow bounds) ] >>> >>> >>> For one hand this solve the problem of maximized state on moved window, >>> and for other hand apply recursive "moving" of window based in their current >>> bounds (but not usable display area) if that is not in state maximize (I >>> choose this rule for my convenience). >>> >>> --- >>> >>> When I load new version of this package, I use the Settings to see new >>> version de la barra, but the old version keep visible too, and I use >>> SHIFT-ALT-Click to see the halos and remove this. Is possible clean up of >>> older versions of bar automatically? >>> >>> ---- >>> >>> And I see that you comming work in TWMWindowSnapshot :) I like it, I hate >>> wasting time accommodating the size and position of the windows manually >>> because I want to have another hearing, again and again! >>> >>> >>> >> >

May 31, 2011

Re: [Pharo-project] A radical proposal (to cut down dead code)

by laurent laffont

Another idea (don't know how hard it is) is to have test coverage + comment coverage in Hudson. Then we can start to consider that dead code = code with no test or no comment. Laurent. On Sat, May 28, 2011 at 3:35 PM, Marcus Denker <marcus.denker(a)inria.fr>wrote: > Hi, > > There is *a lot* of dead code in the image. > > I guess around 1/3 of the code base in Core is just not used at all > (especially Morphic). > > One thing I would like to do is to put, at the beginning of a development > cycle, > a call > > self doesAnyOneUseThisTaggedIn: 'pharo 1.3'. > > at the beginning of *all* unsent methods. And keep it even in the released > image. > > This way we can, within 2-3 interations, remove *a lot* of dead code. > > Methods where people tell us that they need them, we should tag > with <api> or <public> or something like that. > > > Marcus > > -- > Marcus Denker -- http://www.marcusdenker.de > INRIA Lille -- Nord Europe. Team RMoD. > > >

May 31, 2011

Re: [Pharo-project] [Pharo-users] [COTDC] 68 - MultiNewParagraph

by laurent laffont

Thanks a lot Alain !!! Laurent. On Sun, May 29, 2011 at 3:33 AM, Alain Plantec <alain.plantec(a)yahoo.com>wrote: > Class intention > My intention is the same as my super class. This is a good reason to > merge me with my super class and to remove me. > My main supplementary intention is to display the different kinds of > text selection (secondary, find-replace and selection bar). > > Class collaborations > SelectionBlock instances are built by myself and stored in the > extraSelectionBlocks instance variable in order to display supplementary > selections > > Class main API > no particular main API. > > > Instance Variables > extraSelectionBlocks: <Collection of SelectionBlock> > findReplaceSelectionRegex: <RxMatcher> > presentationLines: <Object> > presentationText: <Object> > refreshExtraSelection: <Boolean> > secondarySelection: <String> > > extraSelectionBlocks > - a collection of SelectionBlock for the drowing of the differents kind > of text selection > > findReplaceSelectionRegex > - the find/replace matcher that is set from the editor of by the > FindReplaceService > > presentationLines > - created for debugging purpose, should be removed ? > > presentationText > - created for debugging purpose, should be removed ? > > refreshExtraSelection > - a boolean that is set to tru when there is a need to refresh > selections > > secondarySelection > - the string of the secondary selection that is set from the editor when > a portion of text is selected > > > > Le 25/05/2011 22:50, laurent laffont a Ã©crit : > >> On Tue, May 24, 2011 at 11:15 PM, Igor Stasenko <siguctua(a)gmail.com<mailto: >> siguctua(a)gmail.com>> wrote: >> >> On 24 May 2011 22:31, laurent laffont <laurent.laffont(a)gmail.com >> <mailto:laurent.laffont@gmail.com>> wrote: >> > Today: MultiNewParagraph >> >> Alain Plantec could say more, since more of the methods in this class >> marked under his authorship. >> >> >> >> Alain, do you have 5mn :) ? >> >> Laurent. >> >> >> > Comment Of The Day Contest - One Day One Comment >> > Rules: >> > #1: Each day a not commented class is elected. Each day the best >> comment >> > will be integrated with name of the author(s). >> > #2: If you cannot comment it, deprecate it. >> > Results: http://code.google.com/p/pharo/wiki/CommentOfTheDayContest >> > Laurent >> >> >> >> -- >> Best regards, >> Igor Stasenko AKA sig. >> >> >> >

May 31, 2011

Re: [Pharo-project] A radical proposal (to cut down dead code)

by Igor Stasenko

On 31 May 2011 05:27, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > > > On Mon, May 30, 2011 at 6:50 PM, Craig Latta <craig(a)netjam.org> wrote: >> >> > [It's] impossible to authoritatively classify anything as "dead >> > code" unless there's a reference standard of what's core and what's >> > not core... >> >> Â Â Yeah, in the meantime I define "dead" as "not run for some amount >> of time". > > Surely "dead" means not used in the transitive closure of useful packages. > Â I don't see anyone in this thread proposing to trawl Monticello > repositories looking for the latest versions of packages and then analysing > what messages these packages send. Â IMO, only by doing this will you be able > to define what's used in the image. Â One could try and relate the messages > used to the publish date of packages to try and get some idea of the > up-to-date-ness of messages. Â One can perhaps attempt to make some > determination of the liveness of the package by asking the community (basing > this on e.g. last time it was downloaded creates the heisenbug of package > trawling needing to download packages. > Am I mad or is the set of packages out there in Monitcello repositories and > on SqueakMap what really constitutes the working set that the base image > needs to support? Unless you intentionally want to replace old code with new, and possibly with different API. Then scheme for automatic scanning all users of some code could show you unwanted results. Anyways , i think it is futile to attempt to implement an automated analyzis tool for that. Only developer could say what is dead (or what should be dead) anyways. Of course, things like Ring will help us to analyze the code and track its change history. But still, a final decision, what to call "dead" and what "alive" will always be up to humans. > best, > Eliot -- Best regards, Igor Stasenko AKA sig.

May 31, 2011

Re: [Pharo-project] [Pharo-users] Tiling Window Manager - status update

by Guillermo Polito

I'll change Meta and stuff to match Ctrl, Cmd and Alt tonight. In the current bleeding edge i've splitted shortcut declaration from settings declaration, so we can put shortcuts without putting them in settings. And it avoids the error you had yesterday when resetting the keymaps ;). The problem with CTRL has to do with: http://code.google.com/p/pharo/issues/detail?id=3748&q=events&colspec=ID%20… That I think is a VM bug :( Maybe it has to be one of the first things to have a look at 1.4 On Tue, May 31, 2011 at 3:16 PM, laurent laffont <laurent.laffont(a)gmail.com>wrote: > Thanks Guillermo. > > KeyMapping is really really really important !!! > > Actually shortcuts using CTRL don't work and I would like CTRL + xxx rather > META + xxx for TWM > > Laurent. > > On Tue, May 31, 2011 at 5:08 PM, Guillermo Polito < > guillermopolito(a)gmail.com> wrote: > >> I've freezed the version of keymapping you use in TilingWindowManager with >> number 1.7: >> >> Gofer it >> squeaksource: 'ShortWays'; >> package: 'ConfigurationOfKeymapping'; >> load. >> >> (Smalltalk at: #ConfigurationOfKeymapping project version: '1.7') load. >> >> Because I'm doing some changes >> >> >> On Mon, May 30, 2011 at 6:22 PM, laurent laffont < >> laurent.laffont(a)gmail.com> wrote: >> >>> First thanks to all people that send patches (and tests !!). Still not >>> haven't merged all of them - don't hesitate to post in repository so code is >>> not lost. Yes I will merge layout policies. >>> >>> Gofer it >>> squeaksource: 'TilingWindowManager'; >>> package: 'TWM'; >>> load. >>> (Smalltalk at: #StandardUITheme) beCurrent. >>> (Smalltalk at: #TWMBar) showTWMBar:true. >>> >>> Tested on PharoCore 1.2 and Pharo 1.3. >>> >>> Now this has support for world snapshot, that means you can arrange the >>> windows and take a snapshot of the layout. Then you can restore these >>> layouts later. (icons camera, <, > and trash). I'm not entirely satisfied >>> with this, thanks for feedback. >>> >>> >>> In Pharo 1.3 there's initial integration with KeyMapping. To load: >>> >>> >>> Gofer it >>> squeaksource: 'ShortWays'; >>> package: 'ConfigurationOfKeymapping'; >>> load. >>> >>> (Smalltalk at: #ConfigurationOfKeymapping project version: #bleedingEdge) >>> load. >>> >>> >>> Then in settings browser > Keymappings > Tiling Window Managers you have >>> all actions of the dock mapped. >>> >>> Not all shortcuts are working, don't know why, if people can test and >>> find good shortcuts thank you. >>> >>> Creating a nice Metacello Configuration for TWM will be appreciated :) >>> >>> >>> Cheers, >>> >>> Laurent Laffont - @lolgzs <http://twitter.com/#%21/lolgzs> >>> >>> Pharo Smalltalk Screencasts: http://www.pharocasts.com/ >>> Blog: http://magaloma.blogspot.com/ >>> Developer group: http://cara74.seasidehosting.st >>> >>> >> >

May 31, 2011

Re: [Pharo-project] [Pharo-users] Tiling Window Manager - status update

by laurent laffont

Thanks Guillermo. KeyMapping is really really really important !!! Actually shortcuts using CTRL don't work and I would like CTRL + xxx rather META + xxx for TWM Laurent. On Tue, May 31, 2011 at 5:08 PM, Guillermo Polito <guillermopolito(a)gmail.com > wrote: > I've freezed the version of keymapping you use in TilingWindowManager with > number 1.7: > > Gofer it > squeaksource: 'ShortWays'; > package: 'ConfigurationOfKeymapping'; > load. > > (Smalltalk at: #ConfigurationOfKeymapping project version: '1.7') load. > > Because I'm doing some changes > > > On Mon, May 30, 2011 at 6:22 PM, laurent laffont < > laurent.laffont(a)gmail.com> wrote: > >> First thanks to all people that send patches (and tests !!). Still not >> haven't merged all of them - don't hesitate to post in repository so code is >> not lost. Yes I will merge layout policies. >> >> Gofer it >> squeaksource: 'TilingWindowManager'; >> package: 'TWM'; >> load. >> (Smalltalk at: #StandardUITheme) beCurrent. >> (Smalltalk at: #TWMBar) showTWMBar:true. >> >> Tested on PharoCore 1.2 and Pharo 1.3. >> >> Now this has support for world snapshot, that means you can arrange the >> windows and take a snapshot of the layout. Then you can restore these >> layouts later. (icons camera, <, > and trash). I'm not entirely satisfied >> with this, thanks for feedback. >> >> >> In Pharo 1.3 there's initial integration with KeyMapping. To load: >> >> >> Gofer it >> squeaksource: 'ShortWays'; >> package: 'ConfigurationOfKeymapping'; >> load. >> >> (Smalltalk at: #ConfigurationOfKeymapping project version: #bleedingEdge) >> load. >> >> >> Then in settings browser > Keymappings > Tiling Window Managers you have >> all actions of the dock mapped. >> >> Not all shortcuts are working, don't know why, if people can test and find >> good shortcuts thank you. >> >> Creating a nice Metacello Configuration for TWM will be appreciated :) >> >> >> Cheers, >> >> Laurent Laffont - @lolgzs <http://twitter.com/#%21/lolgzs> >> >> Pharo Smalltalk Screencasts: http://www.pharocasts.com/ >> Blog: http://magaloma.blogspot.com/ >> Developer group: http://cara74.seasidehosting.st >> >> >

May 31, 2011

[Pharo-project] "Can I use my favorite text editor?"

by Craig Latta

http://tinyurl.com/3dup5p9 (wordpress.com) -- Craig Latta www.netjam.org/resume +31 06 2757 7177 + 1 415 287 3547

May 31, 2011