- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Idea to manager package comment in better way

by Marcus Denker

> On 14 Mar 2018, at 16:40, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > Hi. > > I look at hierarchy of PackageManifest and I was wondering that all these classes are commented but most of packages which they describe are not. > > Also interesting that most of manifest comments are same. > > Then I found that package comment is managed as special class side method #description which is generated when you call "aPackage packageComment: 'test'". > > Now the idea: will not it be better to manage package comment as manifest class comment? > > Manifest is already responsible to describe the package. So it looks logical to have "manifest comment = package comment". > Also it will simplify code and remove duplication of texts. > In addition it will add extra place indicating that package needs to be commented because uncommented classes are marked in the browser. > > What you think? > I would say yesâ¦ this would save actually space: lots of methods removed, and the string would be stored on disk instead of inside the image. Marcus

March 14, 2018

Re: [Pharo-dev] Idea to manager package comment in better way

by Denis Kudriashov

And I found that manifest classes are already commented as package comment. 2018-03-14 16:40 GMT+01:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > Hi. > > I look at hierarchy of PackageManifest and I was wondering that all these > classes are commented but most of packages which they describe are not. > > Also interesting that most of manifest comments are same. > > Then I found that package comment is managed as special class side method > #description which is generated when you call "aPackage packageComment: > 'test'". > > Now the idea: will not it be better to manage package comment as manifest > class comment? > > Manifest is already responsible to describe the package. So it looks > logical to have "manifest comment = package comment". > Also it will simplify code and remove duplication of texts. > In addition it will add extra place indicating that package needs to be > commented because uncommented classes are marked in the browser. > > What you think? > >

March 14, 2018

Idea to manager package comment in better way

by Denis Kudriashov

Hi. I look at hierarchy of PackageManifest and I was wondering that all these classes are commented but most of packages which they describe are not. Also interesting that most of manifest comments are same. Then I found that package comment is managed as special class side method #description which is generated when you call "aPackage packageComment: 'test'". Now the idea: will not it be better to manage package comment as manifest class comment? Manifest is already responsible to describe the package. So it looks logical to have "manifest comment = package comment". Also it will simplify code and remove duplication of texts. In addition it will add extra place indicating that package needs to be commented because uncommented classes are marked in the browser. What you think?

March 14, 2018

Re: [Pharo-dev] Getting IP address of machine from Pharo

by Henrik Sperre Johansen

We don't really, hence things like http://forum.world.st/Pharo-user-Does-SSDP-package-supposed-to-work-on-Phar… ;) Cheers, Henry -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

March 14, 2018

Re: [Pharo-dev] MCMczWriter>>#flush breaks

by Guillermo Polito

There is a fix in here: https://github.com/pharo-project/pharo/pull/1091 On Wed, Mar 14, 2018 at 10:53 AM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > Guille, > > > On 13 Mar 2018, at 20:30, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > > > > > > >> On 13 Mar 2018, at 20:22, Guillermo Polito <guillermopolito(a)gmail.com> > wrote: > >> > >> > >> > >> On Tue, Mar 13, 2018 at 8:08 PM, Sven Van Caekenberghe <sven(a)stfx.eu> > wrote: > >> Hi, > >> > >> I was trying to merge in Zinc changes from the latest Pharo 7 back to > the MC Zinc repos. It seems like MCMczWriter>>#flush breaks [1]. I can save > to the package cache but not to an Http repo, nor copy to it. > >> > >> Guile, has this been tested, or do you no longer use the old MC ? > >> > >> I do not use old MC since some time already... > >> > >> I'll take a look at this tomorrow morning. But if this is broken it > means it was not covered by tests :/ > > > > Guille (I got your name wrong before, sorry about that), > > > > Thanks. Yes there are probably no tests, too bad. > > > > I am guessing, the following is wrong, after your changes: > > > > MCHttpRepository>>#entityStreamContents: aBlock > > "Generate output in a buffer because we need the length" > > > > | stream | > > stream := RWBinaryOrTextStream on: String new. > > aBlock value: stream. > > stream reset. > > ^ (ZnStreamingEntity type: ZnMimeType applicationOctetStream) > > stream: stream; > > contentLength: stream size; > > yourself > > > > there probably should be no String there. > > I changed > > stream := RWBinaryOrTextStream on: String new. > > to > > stream := RWBinaryOrTextStream on: ByteArray new. > > and now I can commit MC again. Not sure if that is the best fix, the idea > is probably to phase out RWBinaryOrTextStream. It would probably also work > to just write to a ByteArray new writeStream then take the bytes/contents > and wrap a read stream around them ... > > >> Sven > >> > >> [1] > >> ByteString(Object)>>error: > >> ByteString(Object)>>errorImproperStore > >> ByteString>>at:put: > >> ZipWriteStream(WriteStream)>>nextPut: > >> [ :ch | self nextPut: ch ] in ZipWriteStream(DeflateStream)>>next:putAll:startingAt: > in Block: [ :ch | self nextPut: ch ] > >> ByteArray(SequenceableCollection)>>do: > >> ZipWriteStream(DeflateStream)>>next:putAll:startingAt: > >> ZipWriteStream(DeflateStream)>>nextPutAll: > >> ZipStringMember(ZipArchiveMember)>>compressDataTo: > >> ZipStringMember(ZipArchiveMember)>>writeDataTo: > >> ZipStringMember(ZipArchiveMember)>>writeTo: > >> [ :member | > >> member writeTo: stream. > >> member endRead ] in ZipArchive>>writeTo: in Block: [ :member | ... > >> OrderedCollection>>do: > >> ZipArchive>>writeTo: > >> MCMczWriter>>flush > >> MCMczWriter class>>fileOut:on: > >> MCVersion>>fileOutOn: > >> [ :s | aVersion fileOutOn: s ] in MCHttpRepository( > MCFileBasedRepository)>>basicStoreVersion: in Block: [ :s | aVersion > fileOutOn: s ] > >> MCHttpRepository>>entityStreamContents: > >> MCHttpRepository>>writeStreamForFileNamed:replace:do: > >> MCHttpRepository(MCFileBasedRepository)>>writeStreamForFileNamed:do: > >> MCHttpRepository(MCFileBasedRepository)>>basicStoreVersion: > >> MCHttpRepository(MCRepository)>>storeVersion: > >> MCHttpRepository(MCFileBasedRepository)>>storeVersion: > >> [ super storeVersion: aVersion ] in MCHttpRepository>>storeVersion: in > Block: [ super storeVersion: aVersion ] > >> BlockClosure>>on:do: > >> MCHttpRepository>>retryOnCredentialRequest: > >> MCHttpRepository>>storeVersion: > >> MCWorkingCopyBrowser>>storeVersion:in: > >> [ self > >> storeVersion: newVersion in: aRepository; > >> storeDependencies: newVersion in: aRepository ] in [ [ self > >> storeVersion: newVersion in: aRepository; > >> storeDependencies: newVersion in: aRepository ] > >> ensure: [ (MCVersionInspector new version: newVersion) show ] ] > in MCWorkingCopyBrowser>>basicSaveVersionIn: in Block: [ self... > >> > >> > >> > >> > >> > >> -- > >> > >> Guille Polito > >> Research Engineer > >> > >> Centre de Recherche en Informatique, Signal et Automatique de Lille > >> CRIStAL - UMR 9189 > >> French National Center for Scientific Research - http://www.cnrs.fr > >> > >> Web: http://guillep.github.io > >> Phone: +33 06 52 70 66 13 > > > -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

March 14, 2018

Re: [Pharo-dev] Epicea changes broken in latest 7

by Guillermo Polito

I cannot reproduce it from here... does your file have non-ascii characters? On Wed, Mar 14, 2018 at 10:55 AM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > World Menu > Tools > Code Changes > > click on any change, boom. > > [ :error | > (OmFileStoreReadingError > readingError: error > on: self fileReference > position: readStream position) signal ] in [ :readStream | > [ ^ aBlockClosure value: readStream ] > on: Error > do: [ :error | > (OmFileStoreReadingError > readingError: error > on: self fileReference > position: readStream position) signal ] ] in > OmBlockFileStore(OmFileStore)>>readEntriesWith: in Block: [ :error | ... > BlockClosure>>cull: > Context>>evaluateSignal: > Context>>handleSignal: > Context>>handleSignal: > MessageNotUnderstood(Exception)>>signal > UndefinedObject(Object)>>doesNotUnderstand: #< > ZnUTF8Encoder>>nextCodePointFromStream: > ZnUTF8Encoder(ZnCharacterEncoder)>>nextFromStream: > ZnCharacterReadStream>>nextElement > [ :out | > | partialMatch pattern matched | > partialMatch := (self collectionSpecies new: aCollection size) > writeStream. > pattern := aCollection readStream. > matched := false. > [ matched or: [ self atEnd or: [ pattern atEnd ] ] ] > whileFalse: [ | ch | > (ch := self nextElement) = pattern next > ifTrue: [ pattern atEnd > ifTrue: [ matched := true ] > ifFalse: [ partialMatch nextPut: > ch ] ] > ifFalse: [ pattern reset. > out nextPutAll: partialMatch contents. > partialMatch reset. > out nextPut: ch ] ]. > matched > ifFalse: [ out nextPutAll: partialMatch contents ] ] in > ZnCharacterReadStream>>upToAll: in Block: [ :out | ... > String class(SequenceableCollection class)>>new:streamContents: > String class(SequenceableCollection class)>>streamContents: > ZnCharacterReadStream>>upToAll: > [ stream upToAll: token ] in OmSTONEntryReader>>nextEntryPositionIfFound:ifNone: > in Block: [ stream upToAll: token ] > BlockClosure>>on:do: > OmSTONEntryReader>>nextEntryPositionIfFound:ifNone: > OmSTONEntryReader>>entryPositionsDo: > OmSTONEntryReader>>entryPositionsUpTo: > [ :readStream | > readStream position: startPosition. > ^ self newEntryReader > stream: readStream; > entryPositionsUpTo: endPosition ] in OmBlockFileStore>>entryPositionsStartingAt:upTo: > in Block: [ :readStream | ... > [ ^ aBlockClosure value: readStream ] in [ :readStream | > [ ^ aBlockClosure value: readStream ] > on: Error > do: [ :error | > (OmFileStoreReadingError > readingError: error > on: self fileReference > position: readStream position) signal ] ] in > OmBlockFileStore(OmFileStore)>>readEntriesWith: in Block: [ ^ > aBlockClosure value: readStream ] > BlockClosure>>on:do: > [ :readStream | > [ ^ aBlockClosure value: readStream ] > on: Error > do: [ :error | > (OmFileStoreReadingError > readingError: error > on: self fileReference > position: readStream position) signal ] ] in > OmBlockFileStore(OmFileStore)>>readEntriesWith: in Block: [ :readStream | > ... > [ aBlock value: stream ] in FileReference(AbstractFileReference)>>readStreamDo: > in Block: [ aBlock value: stream ] > BlockClosure>>ensure: > FileReference(AbstractFileReference)>>readStreamDo: > OmBlockFileStore(OmFileStore)>>readEntriesWith: > OmBlockFileStore>>entryPositionsStartingAt:upTo: > OmBlock>>refresh > OmBlock>>checkIfMustRefreshBlock > > > -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

March 14, 2018

Re: [Pharo-dev] Getting IP address of machine from Pharo

by Denis Kudriashov

Yes, external lib is an option. I expected that we already have something in the image. 2018-03-14 11:34 GMT+01:00 Julien <julien.delplanque(a)inria.fr>: > Ok, this one you can get it (for each network interface) via > > $ ifconfig > > In the command line. So I guess it should be possible to ask the OS via a > FFI call what is the address. > > I donât know what is done in Pharo about that. > > Apparently, on Linux using C, it is possible to get the IP address of an > interface via a call to getifaddrs [1]. > > I donât know what is the method to do that on Mac OS. > > Julien > > Links: > [1]: http://man7.org/linux/man-pages/man3/getifaddrs.3.html > > --- > Julien Delplanque > Doctorant Ã lâUniversitÃ© de Lille 1 > http://juliendelplanque.be/phd.html > Equipe Rmod, Inria > BÃ¢timent B 40, Avenue Halley 59650 > <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> > Villeneuve > <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> > d'Ascq > <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> > NumÃ©ro de tÃ©lÃ©phone: +333 59 35 86 40 <+33%203%2059%2035%2086%2040> > > Le 14 mars 2018 Ã 11:28, Denis Kudriashov <dionisiydk(a)gmail.com> a Ã©crit : > > 2018-03-14 11:14 GMT+01:00 Julien <julien.delplanque(a)inria.fr>: > >> What do you mean by your IP address, on your local network or the one >> seen by external servers when you connect to them? >> > > I need address in my local network. > > >> >> If I remember well, the IP address seen by computers outside your local >> network is not the IP address of your actual computer but the one of the >> router connecting your local network to the outside web. >> >> I am not sure you can get the outside IP address without asking it to a >> computer outside your local network but I might be wrong. >> >> Julien >> >> --- >> Julien Delplanque >> Doctorant Ã lâUniversitÃ© de Lille 1 >> http://juliendelplanque.be/phd.html >> Equipe Rmod, Inria >> BÃ¢timent B 40, Avenue Halley 59650 >> <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> >> Villeneuve >> <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> >> d'Ascq >> <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> >> NumÃ©ro de tÃ©lÃ©phone: +333 59 35 86 40 <+33%203%2059%2035%2086%2040> >> >> Le 14 mars 2018 Ã 11:07, Denis Kudriashov <dionisiydk(a)gmail.com> a Ã©crit >> : >> >> Hello. >> >> Do we have a way to retrieve IP address from Pharo? >> I tried to use following code: >> >> NetNameResolver addressForName: NetNameResolver localHostName >> >> But it either not works (dialog with retry give-up options) or returns >> localhost 127.0.0.1. >> >> Best regards, >> Denis >> >> >> > >

March 14, 2018

Re: [Pharo-dev] Getting IP address of machine from Pharo

by Julien

Ok, this one you can get it (for each network interface) via $ ifconfig In the command line. So I guess it should be possible to ask the OS via a FFI call what is the address. I donât know what is done in Pharo about that. Apparently, on Linux using C, it is possible to get the IP address of an interface via a call to getifaddrs [1]. I donât know what is the method to do that on Mac OS. Julien Links: [1]: http://man7.org/linux/man-pages/man3/getifaddrs.3.html --- Julien Delplanque Doctorant Ã lâUniversitÃ© de Lille 1 http://juliendelplanque.be/phd.html Equipe Rmod, Inria BÃ¢timent B 40, Avenue Halley 59650 Villeneuve d'Ascq NumÃ©ro de tÃ©lÃ©phone: +333 59 35 86 40 > Le 14 mars 2018 Ã 11:28, Denis Kudriashov <dionisiydk(a)gmail.com> a Ã©crit : > > 2018-03-14 11:14 GMT+01:00 Julien <julien.delplanque(a)inria.fr <mailto:julien.delplanque@inria.fr>>: > What do you mean by your IP address, on your local network or the one seen by external servers when you connect to them? > > I need address in my local network. > > > If I remember well, the IP address seen by computers outside your local network is not the IP address of your actual computer but the one of the router connecting your local network to the outside web. > > I am not sure you can get the outside IP address without asking it to a computer outside your local network but I might be wrong. > > Julien > > --- > Julien Delplanque > Doctorant Ã lâUniversitÃ© de Lille 1 > http://juliendelplanque.be/phd.html <http://juliendelplanque.be/phd.html> > Equipe Rmod, Inria > BÃ¢timent B 40, Avenue Halley 59650 <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> Villeneuve <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> d'Ascq <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> > NumÃ©ro de tÃ©lÃ©phone: +333 59 35 86 40 <tel:+33%203%2059%2035%2086%2040> > >> Le 14 mars 2018 Ã 11:07, Denis Kudriashov <dionisiydk(a)gmail.com <mailto:dionisiydk@gmail.com>> a Ã©crit : >> >> Hello. >> >> Do we have a way to retrieve IP address from Pharo? >> I tried to use following code: >> >> NetNameResolver addressForName: NetNameResolver localHostName >> >> But it either not works (dialog with retry give-up options) or returns localhost 127.0.0.1. >> >> Best regards, >> Denis > >

March 14, 2018

Re: [Pharo-dev] Getting IP address of machine from Pharo

by Denis Kudriashov

2018-03-14 11:14 GMT+01:00 Julien <julien.delplanque(a)inria.fr>: > What do you mean by your IP address, on your local network or the one seen > by external servers when you connect to them? > I need address in my local network. > > If I remember well, the IP address seen by computers outside your local > network is not the IP address of your actual computer but the one of the > router connecting your local network to the outside web. > > I am not sure you can get the outside IP address without asking it to a > computer outside your local network but I might be wrong. > > Julien > > --- > Julien Delplanque > Doctorant Ã lâUniversitÃ© de Lille 1 > http://juliendelplanque.be/phd.html > Equipe Rmod, Inria > BÃ¢timent B 40, Avenue Halley 59650 > <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> > Villeneuve > <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> > d'Ascq > <https://maps.google.com/?q=40,+Avenue+Halley+59650+Villeneuve+d'Ascq&entry=gmail&source=g> > NumÃ©ro de tÃ©lÃ©phone: +333 59 35 86 40 <+33%203%2059%2035%2086%2040> > > Le 14 mars 2018 Ã 11:07, Denis Kudriashov <dionisiydk(a)gmail.com> a Ã©crit : > > Hello. > > Do we have a way to retrieve IP address from Pharo? > I tried to use following code: > > NetNameResolver addressForName: NetNameResolver localHostName > > But it either not works (dialog with retry give-up options) or returns > localhost 127.0.0.1. > > Best regards, > Denis > > >

March 14, 2018

Re: [Pharo-dev] Getting IP address of machine from Pharo

by Benoit St-Jean

This is probably what you are looking for (one of the code snippets does exactly what you want). http://forum.world.st/Figuring-out-external-IP-addresses-of-network-interfa… As for services/websites you can query to get the public ip address, here's a short list (you'll have to modify the example above to parse the response correctly): http://checkip.dyndns.com https://www.whatismypublicip.com/ http://freegeoip.net https://who.is/ http://www.ipchicken.com/ http://www.whatsmyip.org/ https://api.ipify.org/ https://whatismyipaddress.com/ IMHO, the simplest is api.ipify.org.Â However, note that some of those service also answer geolocation info! ----------------- BenoÃ®t St-Jean Yahoo! Messenger: bstjean Twitter: @BenLeChialeux Pinterest: benoitstjean Instagram: Chef_Benito IRC: lamneth Blogue: endormitoire.wordpress.com "A standpoint is an intellectual horizon of radius zero".Â (A. Einstein) On Wednesday, March 14, 2018, 6:08:41 AM EDT, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: Hello. Do we have a way to retrieve IP address from Pharo?I tried to use following code: NetNameResolver addressForName: NetNameResolver localHostNameÂ But it either not works (dialog with retry give-up options) or returns localhost 127.0.0.1. Best regards,Denis

March 14, 2018